Bug 1918808

Created attachment 1749434 [details]
Screencast of the selections in the Create storageclass page

Description of problem:
===============================

As seen in the attached screenshot and the screencast, when one clicks on Create STorage class and selects the RBD provisioner from drop down, user gets the option to "Enable Encryption".

When we select the Pool and Enable Encryption, following warning is shown in the screen:

>> Warning alert:Encrypted PVs cannot be cloned expanded or create snapshots.

But even though this message is reported in the screen, users are still able to select the checkbox and once created, the Storageclass has the "allowVolumeExpansion: true"

>>Allow persistent volume claims to be expanded

Version-Release number of selected component (if applicable):
==============================================================
OCP = 4.7.0-0.nightly-2021-01-19-095812
OCS = ocs-operator.v4.7.0-235.ci

How reproducible:
=================
Always

Steps to Reproduce:
=========================
1. With OCS installed, navigate to Storage->Storageclass->Create Storageclass
2. Select "provisioner: openshift-storage.rbd.csi.ceph.com"
3. Select the pool and the Enable encryption comes up on the screen
4. Click on Enable Encryption and you will see the message 
"Warning alert:Encrypted PVs cannot be cloned expanded or create snapshots."
5. But I am still able to click on the checkbox for "Allow persistent volume claims to be expanded" which is contradictory

Actual results:
==================
Even though the warning message says encrypted PVs cannot be expanded, then why do we allow users to select the checkbox for Volume expansion in the same Storageclass. 

Expected results:
======================
If users select Enable Encryption, then the checkbox for "Allow persistent volume claims to be expanded" should become mooted.

Additional info:
=====================
$ oc get sc test-kms-sc -o yaml
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  creationTimestamp: "2021-01-21T08:05:03Z"
  managedFields:
  - apiVersion: storage.k8s.io/v1
    fieldsType: FieldsV1
    fieldsV1:
      f:allowVolumeExpansion: {}
      f:parameters:
        .: {}
        f:clusterID: {}
        f:csi.storage.k8s.io/controller-expand-secret-name: {}
        f:csi.storage.k8s.io/controller-expand-secret-namespace: {}
        f:csi.storage.k8s.io/fstype: {}
        f:csi.storage.k8s.io/node-stage-secret-name: {}
        f:csi.storage.k8s.io/node-stage-secret-namespace: {}
        f:csi.storage.k8s.io/provisioner-secret-name: {}
        f:csi.storage.k8s.io/provisioner-secret-namespace: {}
        f:encrypted: {}
        f:encryptionKMSID: {}
        f:imageFeatures: {}
        f:imageFormat: {}
        f:pool: {}
      f:provisioner: {}
      f:reclaimPolicy: {}
      f:volumeBindingMode: {}
    manager: Mozilla
    operation: Update
    time: "2021-01-21T08:05:03Z"
  name: test-kms-sc
  resourceVersion: "615579"
  selfLink: /apis/storage.k8s.io/v1/storageclasses/test-kms-sc
  uid: be176785-fec8-491e-aca8-03851fb39364
parameters:
  clusterID: openshift-storage
  csi.storage.k8s.io/controller-expand-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/controller-expand-secret-namespace: openshift-storage
  csi.storage.k8s.io/fstype: ext4
  csi.storage.k8s.io/node-stage-secret-name: rook-csi-rbd-node
  csi.storage.k8s.io/node-stage-secret-namespace: openshift-storage
  csi.storage.k8s.io/provisioner-secret-name: rook-csi-rbd-provisioner
  csi.storage.k8s.io/provisioner-secret-namespace: openshift-storage
  encrypted: "true"
  encryptionKMSID: 1-VAULT
  imageFeatures: layering
  imageFormat: "2"
  pool: ocs-storagecluster-cephblockpool
provisioner: openshift-storage.rbd.csi.ceph.com
reclaimPolicy: Delete
volumeBindingMode: Immediate