Bug 192060

Good:
* Tar in source RPM is the same as upstream
* Local build work fine
* Mock build worde fine.

Bad:
- Duplicate BuildRequires: SDL-devel (by SDL_mixer-devel)

"This is Episode I of the Blob Wars Saga."

So where will I find Episode II?  ;)

There is a stray "export" in the %build section.  Leftover from debugging perhaps?

(In reply to comment #1)
> 
> Bad:
> - Duplicate BuildRequires: SDL-devel (by SDL_mixer-devel)

Your right, but thats a minor issue, I'll fix it after import, or in a second
release / attempt if more issue are found during a proper review.

(In reply to comment #2)
> "This is Episode I of the Blob Wars Saga."
> 
> So where will I find Episode II?  ;)
> 

Episode II isn't finished yet but its undergoing active development and
a functional demo is downloadable:
http://www.parallelrealities.co.uk/blobAndConquer.php

> There is a stray "export" in the %build section.  Leftover from debugging perhaps?

My bad, it had an export CFLAGS=.... then I thought I could just as well pass
that directly to make, so I cut and pasted it to the make line and appearantly
forgot to remove the export.

Review for release 1:
* RPM name is OK
* Source blobwars_1.05.orig.tar.gz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Works fine, including sound

* rpmlint output clean
* Package named according to Package Naming Guidelines
* spec file name matches package %{name}
* Package meets Packaging Guidelines
* Licensed with open source compatible license
* License field in spec file matches actual license
* License text included in %doc
* spec file written in American English
* spec file is legible
* Sources match upstream
72b259abb6ec83a77f3c76052de24e50  blobwars_1.05.orig.tar.gz
* Package successfully compiles and builds on x86_64 FC-5
* All dependencies are specified in BuildRequires

- SDL-devel and ImageMagick are extraneous BR

* Spec file does not include any locales
* Package does not include any shared libraries
* Package is not relocatable
* Package owns all directories it creates
* Package does not contain duplicate files in %files
* File permissions are set appropriately
* Package contains a proper %clean section
* Macro usage is consistant
* Package contains permissible content
* Package does not contain large documentation to warrent a -doc subpackage
* Package does not contain any header files, static libraries or .pc files
* Package does not include any library files needed for a -devel subpackage
* Package does not contain any .la files
* Package includes a proper .desktop file
* Package does not own any files or directories owned by other packages


=== MUST FIX ====
* MUST remove extreanous BR SDL-devel and ImageMagick
* MUST remove extreanous "export" in %build section
* MUST remove extreanous "-n %{name}-%{version}" under %setup

=== SHOULD ===
* Please explain to me why you use patch -z, most examples I've seen use patch
-b and I don't understand the differences between these two options.  I'm not
asking you to use -b, but just explain to me why you use -z.  Thanks!

Additional comment (SHOULD FIX):

/var/tmp/blobwars-1.05-1-root-mockbuild/usr/share/applications/fedora-blobwars.desktop:
warning: boolean key "Terminal" has value "0", boolean values should be "false"
or "true", although "0" and "1" are allowed in this field for backwards
compatibility

NOTE SHOULD FIX:  If you are planning on fixing the .desktop file, I will also
recommend you call the game "Blob Wars: Metal Blob Solid" instead of just "Metal
Blob Solid".  This will make it easier to locate and will be easier when Part II
is released.

(In reply to comment #5)
> === SHOULD ===
> * Please explain to me why you use patch -z, most examples I've seen use patch
> -b and I don't understand the differences between these two options.  I'm not
> asking you to use -b, but just explain to me why you use -z.  Thanks!

There is no difference, the syntax when calling the real patch is
patch -pX -b -z .suffix

Where -b forces backups and -z .suffix sets the suffix, hence I use -z .suffix
as that comes closes to the real patch.
%patch has either of:
%patch -pX -z .suffix
%patch -pX -b .suffix

And adss the -b before the -z or the -z between the -b and the .suffix (sigh).
So %patch is a bit weird.

I hope that explains. Here is a new version with fixes all MUST fix and should
fix items:
Spec URL: http://people.atrpms.net/~hdegoede/blobwars.spec
SRPM URL: http://people.atrpms.net/~hdegoede/blobwars-1.05-2.src.rpm

I don't want to be rude, but ping?

What more do you need me to do?  I approved this package a week ago...

Oops, sorry

It seems that I don't get bugzilla mails when only the blocker bug changes (I'll
change my bugzilla mail settings to fix this). I'm kinda used to people adding a
comment when the approve.

Apologies!

Imported and finally build (buildsys troubles), closing.