Bug 1920675

Summary:	Noise Reduction is not enabled
Product:	[Fedora] Fedora	Reporter:	daniel g. siegel <dgsiegel>
Component:	pulseeffects	Assignee:	Vasiliy Glazov <vascom2>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	33	CC:	ego.cordatus, roberttucker, vascom2
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	pulseeffects-5.0.1-2.fc34 pulseeffects-4.8.4-2.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-19 20:16:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1919606
Bug Blocks:

Description daniel g. siegel 2021-01-26 20:39:53 UTC

Description of problem:

Pulseeffects offers a plugin for noise reduction, based on rnnoise. Unfortunately it does not work, as Pulseeffects was compiled without rnnoise being present.

Steps to Reproduce:
1. Activate Noise Reduction
2. Find a greyed out panel signalling it is not enabled

Additional info:

Probably depends on https://bugzilla.redhat.com/show_bug.cgi?id=1919606

Also this COPR has support for noise reduction: https://copr.fedorainfracloud.org/coprs/seandarcy/rnnoise/

Comment 1 Vasiliy Glazov 2021-01-27 03:59:15 UTC

If you install rnnoise from copr it work in pulseeffects from repo?

While rnnoise not in repo I can't build with it or add as require.

Comment 2 daniel g. siegel 2021-01-27 15:25:53 UTC

> If you install rnnoise from copr it work in pulseeffects from repo?

No you have to install rnnoise _and_ pulseeffects built with rnnoise installed to make this work.

> While rnnoise not in repo I can't build with it or add as require.

It is already in rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=60332314

Comment 3 Robert Tucker 2021-03-09 00:46:39 UTC

The author of pulseeffects says, "The rnnoise library has to be installed in the system at the moment the PulseEffects package is compiled."
https://github.com/wwmm/pulseeffects/issues/910

"copr worked. ... I just built rnnoise, copr-cli build rnnoise.srpm. waited for it to finish. Added rnnoise to buildrequires and requires in the pulseeffects spec. Built that srpm. And bingo."
https://www.reddit.com/r/Fedora/comments/kndcdz/koji_build_one_package_after_another/

I built rnnoise using an edited SUSE spec file and pulseeffects using an edited version of Vasiliyi's spec file:
https://copr.fedorainfracloud.org/coprs/rtfed/pulseeffects-rnnoise/

I did:
$ sudo rpmbuild -vv --rebuild rnnoise-0-0.src.rpm
$ sudo rpmbuild -vv --rebuild pulseeffects-5.0.1-1.fc33.src.rpm
then installed the rpm's produced. But no "bingo" – "Noise reduction" is still greyed out.

I also used pip3 to install python3-keras. But when I had it as BuildRequires in the rnnoise spec, it wouldn't find it. ???

Comment 4 Vasiliy Glazov 2021-03-09 05:29:45 UTC

You have to install rnnoise-devel before rebuild pulseeffects.

Comment 5 Robert Tucker 2021-03-09 10:15:11 UTC

(In reply to Vasiliy Glazov from comment #4)
> You have to install rnnoise-devel before rebuild pulseeffects.

Thanks that's got it. I've now put installation instructions on my copr page.

Comment 6 Fedora Update System 2021-03-15 10:21:35 UTC

FEDORA-2021-789f8bc7d2 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-789f8bc7d2

Comment 7 Fedora Update System 2021-03-15 10:26:20 UTC

FEDORA-2021-88f59f45e1 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-88f59f45e1

Comment 8 Fedora Update System 2021-03-15 20:01:00 UTC

FEDORA-2021-789f8bc7d2 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-789f8bc7d2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-789f8bc7d2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Robert Tucker 2021-03-16 07:35:25 UTC

My COPR build of PulseEffects 5 does run on FC33 if pipewire is installed. The rawhide FC34 build requires a higher version of Boost, I remember discovering.

If rnnoise is going into the repos as version 0-0.3.2, people will want to use that rather than my COPR build unless they do a dnf/yum exclude, or I do a COPR build with an equal or higher version designation. Though as long as they are built from the same git version ...

Comment 10 Vasiliy Glazov 2021-03-16 07:48:24 UTC

What is your question?

Comment 11 Robert Tucker 2021-03-16 07:53:45 UTC

I was really essentially just adding information should anyone wish to have PE5 on FC33.

The testing PE4 version for FC33 doesn't require pipewire?

Comment 12 Vasiliy Glazov 2021-03-16 08:29:26 UTC

Yes.
PE 4 designed only for pulseaudio.
PE 5 designed only for pipewire.

All current versions in testing support rnnoise.

Thanks for your copr with PE 5 for F33.

Comment 13 Fedora Update System 2021-03-16 14:42:48 UTC

FEDORA-2021-88f59f45e1 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-88f59f45e1 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-88f59f45e1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2021-03-19 20:16:05 UTC

FEDORA-2021-88f59f45e1 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2021-03-21 01:22:53 UTC

FEDORA-2021-789f8bc7d2 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.