Bug 1920683

Summary:	when chroot is turn off, munge symlinks is enabled by default
Product:	Migration Toolkit for Containers	Reporter:	Alay Patel <alpatel>
Component:	Controller	Assignee:	Shawn Hurley <shurley>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	unspecified	Docs Contact:	Avital Pinnick <apinnick>
Priority:	unspecified
Version:	1.4.0	CC:	ernelson, rjohnson, sregidor
Target Milestone:	---
Target Release:	1.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-11 12:55:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alay Patel 2021-01-26 21:12:11 UTC

Description of problem:
When use chroot = no is configured in rsyncd.conf, the munge syslink option is enabled by default. This will break the symlinks on the source pvc and make those files unusable



Version-Release number of selected component (if applicable):
1.4.0

How reproducible:
Always

Steps to Reproduce:
1. Take a source pvc, create a syslink in the pvc
2. Run a migration

Actual results:
unusable symlinks

------
sh-4.2$ ls /var/lib/pgsql/data
temp0  temp1  user0  user1
sh-4.2$ ls -larth /var/lib/pgsql/data
total 20K
drwxrwx---. 3 postgres   root   18 Sep 21 15:40 ..
-rw-r--r--. 1 1000080000 2011    6 Jan 25 17:05 temp0
drwxrwxrwx. 4 root       2011 4.0K Jan 25 17:05 .
-rw-r--r--. 1 1000080000 2011    6 Jan 25 17:05 temp1
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:42 user0
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:45 user1
sh-4.2$ ls -larth /var/lib/pgsql/data/user*
/var/lib/pgsql/data/user0:
total 12K
drwxrwxrwx. 4 root       2011 4.0K Jan 25 17:05 ..
-rw-r--r--. 1 1000080000 2011    6 Jan 25 17:08 temp0
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:42 .
-rw-r--r--. 1 root       2011    0 Jan 26 20:42 s-link
/var/lib/pgsql/data/user1:
total 12K
drwxrwxrwx. 4 root       2011 4.0K Jan 25 17:05 ..
-rw-r--r--. 1 1000080001 2011    6 Jan 25 17:08 temp1
lrwxrwxrwx. 1 root       2011   30 Jan 26 20:45 s-link0 -> /rsyncd-munged/../user0/s-link
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:45 .
sh-4.2$ ls /rsyncd-munged/../user0/s-link
ls: cannot access /rsyncd-munged/../user0/s-link: No such file or directory



Expected results:
Symlinks should stay as is

----
sh-4.4# ls -larth /mnt/permissions/pvc-0/
total 20K
-rw-r--r--. 1 1000080000 2011    6 Jan 25 17:05 temp0
drwxrwsr-x. 4 root       2011 4.0K Jan 25 17:05 .
-rw-r--r--. 1 1000080000 2011    6 Jan 25 17:05 temp1
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:42 user0
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:45 user1
drwxr-xr-x. 3 root       root   19 Jan 26 21:05 ..
sh-4.4# ls -larth /mnt/permissions/pvc-0/user*
/mnt/permissions/pvc-0/user0:
total 12K
drwxrwsr-x. 4 root       2011 4.0K Jan 25 17:05 ..
-rw-r--r--. 1 1000080000 2011    6 Jan 25 17:08 temp0
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:42 .
-rw-r--r--. 1 root       2011    0 Jan 26 20:42 s-link

/mnt/permissions/pvc-0/user1:
total 12K
drwxrwsr-x. 4 root       2011 4.0K Jan 25 17:05 ..
-rw-r--r--. 1 1000080001 2011    6 Jan 25 17:08 temp1
lrwxrwxrwx. 1 root       2011   15 Jan 26 20:45 s-link0 -> ../user0/s-link
drwxrwsr-x. 2 root       2011 4.0K Jan 26 20:45 .


Additional info:

Comment 4 Sergio 2021-01-29 10:30:03 UTC

Verified using MTC 1.4.0, AWS OCP3.11 -> AWS OCP4.5 (AWS S3) storageclass gp2.

openshift-migration-rhel7-operator@sha256:8e736547673398a34570aaa041ce57743eb62e59a715e7dfb3a91ecbd3a259b3
    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: 1812d8ee7138b8c976179f33798a17cfd4b4644b33cdcf62b6fa70c262b084c6


Links are migrated without problems and they are working fine after the migration.

Moved to verified.

Comment 6 errata-xmlrpc 2021-02-11 12:55:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5329