Bug 192086

Hi,

I've been busy the last 2 days packaging tuxkart which uses plib. During this
packaging I've found both a bug and a missing feature in plib, wich are both
fixed by the attached patch:
-The bug is that plib (pw) creates a resizable window, but that tuxkart expects
 the window to always be the size it has specified iow it expects a non
 resizable window. Now one could concider this a bug in tuxkart, but its not
 uncommon for games to be written to a hardcoded resolution and not written for
 a resizable window. Besides making the window non resizable is much easier then
 fixing tuxkart. To fix this I've added a new function:
 void pwSetResizable ( bool enable ) ;
 The default behaviour is still to create a resizable window because I didn't
 want to break the api and/or change any defautl behaviour.
-The missing feature is the fact that plib doesn't have fullscreen support, 
 atleast not really:
 * Its possible to create a fullscreen window by passing -1 
   for width and height and disabling the border. But I've tried this (6 months
   ago or so) and there were issues (If I remember correctly the panel was on
   top of the window).
 * Besides the issues their is the problem that in that case your desktop size
   gets used and the application thus cannot specify the size it wants (see
   above). Also the desktop size usually is a rather high resoltution
   which peformance wise is not ideal for 3D games.
 * Last but not least with the current "fullscreen" code its not possible to
   switch between fullscreen <-> window easily.
 * The attached patch uses XF86VidMode to switch to the requested resolution
   instead of always using the desktopsize and it allows easy fullscreen <->
   window switching:
   void pwSetFullscreen () ;
   void pwSetWindowed () ;
   void pwToggleFullscreen () ;
 * Notice that I've choosen not to reuse the border flag for the new fullscreen
   support, so that the behaviour of plib is 100% identical for apps who do not
   use these new functions. If an app wants to use the new fullscreen code it
   must call pwSetFullscreen () after pwInit ().
 * Some apps don't want to show a cursor when fullscreen, whereas a hidden
   cursor in windowed mode is annoying. Thus I've added a new function which
   allows an app to specify seperate cursors for fullscreen and windowed mode:
   void pwSetCursorEx ( int wm, int fs ) ;

Phew, long story. Well thats it I hope you like it! I will also send the patch
upstream for intergration there.

I can understand if you're a bit worried this patch may break other stuff *, so
I would like to offer to co-maintain plib with yopu. If you agree I'll ad myself
to the initial CC field of owners.list so that I get copied on any plib bugs.
(If you want I'm even in for taking plib completly over).

* although the normal code path without using the new functions is hardly
changed, so that really shouldn't happen. 



p.s.

I've also noticed that plib currently creates .a files. For easy pushing of
bugfixes to plib without having to recompile plib I would like to see plib
providing (properly versioned) .so files. Will yuo accept a patch for this?