Bug 1921853
| Summary: | Review Request: rust-derive-new - Derive simple constructor functions for structs and enums | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sohan Kunkerkar <skunkerk> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, eclipseo, igor.raits, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-02-22 11:56:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sohan Kunkerkar
2021-01-28 17:39:11 UTC
First comment: The Summary tag (taken from upstream metadata) is really long, you should probably change it to "Derive simple constructor functions for structs and enums" or similar. And please also use this Summary as the Summary of the Review Request template (in the bug title). I'll make a full review this afternoon. Please ask upstream to include the license file in their crate. (In reply to Robert-André Mauchin 🐧 from comment #2) > Please ask upstream to include the license file in their crate. It seems like the upstream project is not maintained for a while. The last commit was added in 2018. I tried to reach the maintainer of the project, but haven't received any reply yet. (In reply to Robert-André Mauchin 🐧 from comment #2) > Please ask upstream to include the license file in their crate. Alright, the license file is updated in the new crate. Also, some changes in the original content: Spec URL: https://sohank2602.fedorapeople.org/rust-derive-new/rust-derive-new.spec SRPM URL: https://sohank2602.fedorapeople.org/rust-derive-new-0.5.9-1.fc33.src.rpm A LICENSE file is now in the upstream crate, but it's still not added in the package. Add "%license LICENSE" to the %files list for the -devel subpackage. Also please remove the markdown markup (the two `) from the Summary tag. (In reply to Fabio Valentini from comment #5) > A LICENSE file is now in the upstream crate, but it's still not added in the > package. > > Add "%license LICENSE" to the %files list for the -devel subpackage. > > > Also please remove the markdown markup (the two `) from the Summary tag. Thanks for the review! Fixed. Could you take another look? Uhm ... What did you do to Summary and description? I said remove the two `s, not to remove everything between them :) The text itself was fine, just the markup makes no sense in RPM tags ... If you *want* to change the Summary text, do something like this to make it make sense: Summary: Derive simple constructor functions for structs and enums The %description can stay unmodified from the rust2rpm generated .spec. Other than that: package generated with rust2rpm, simplifying the review: - latest version from crates.io is packaged - License matches upstream specification and shipped as %license - follows Packaging and Rust Packaging Guidelines - builds and installs successfully on rawhide Please fix the Summary and %description tags before importing and building the package. > Please fix the Summary and %description tags before importing and building the package.
My bad, it's fixed in the subsequent push.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-derive-new This package is successfully built for F-34 https://koji.fedoraproject.org/koji/buildinfo?buildID=1711325 Thanks Fabio Valentini for the help! *** Bug 1873737 has been marked as a duplicate of this bug. *** |