Bug 1922495

Summary:	%pyproject_buildrequires with %tox don't support tox.requires / tox.minversion
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	pyproject-rpm-macros	Assignee:	Miro Hrončok <mhroncok>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	mhroncok, pviktori, python-sig
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	pyproject-rpm-macros-0-39.fc35 pyproject-rpm-macros-0-39.fc33 pyproject-rpm-macros-0-39.fc32 pyproject-rpm-macros-0-39.fc34	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-04-07 15:55:44 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Miro Hrončok 2021-01-29 21:54:05 UTC

See https://tox.readthedocs.io/en/latest/config.html#conf-requires

Specify python packages that need to exist alongside the tox installation for the tox build to be able to start (must be PEP-508 compliant). Use this to specify plugin requirements (or the version of virtualenv - determines the default pip, setuptools, and wheel versions the tox environments start with). If these dependencies are not specified tox will create provision_tox_env environment so that they are satisfied and delegate all calls to that.

We should generate a BRs for them to avoid an attempt to create the provision_tox_env.




See https://tox.readthedocs.io/en/latest/config.html#conf-minversion

Define the minimal tox version required to run; if the host’s tox version is less than this the tool will create an environment and provision it with a version of tox that satisfies this under provision_tox_env.

We should generate a BR of tox >= minversion to avoid this attempt as well.


Real world problem: https://github.com/jsonpickle/jsonpickle/issues/336#issuecomment-770040295


Technically, such plugins might not work and might even break tox-current-env, but we should IMHO process the data nevertheless.

Comment 1 Miro Hrončok 2021-01-29 21:55:18 UTC

Side note: tox-current-env should prevent provision_tox_env if possible.

Comment 2 Miro Hrončok 2021-01-29 22:13:31 UTC

> Technically, such plugins might not work and might even break tox-current-env

And we should document that.

Comment 3 Ben Cotton 2021-02-09 15:44:31 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 4 Miro Hrončok 2021-03-29 11:47:29 UTC

https://src.fedoraproject.org/rpms/pyproject-rpm-macros/pull-request/149

Comment 5 Fedora Update System 2021-04-07 15:55:44 UTC

FEDORA-2021-2ce860eeca has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 6 Fedora Update System 2021-04-07 15:57:05 UTC

FEDORA-2021-6d80c190a1 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6d80c190a1

Comment 7 Fedora Update System 2021-04-07 15:57:05 UTC

FEDORA-2021-eecece1e00 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-eecece1e00

Comment 8 Fedora Update System 2021-04-07 15:57:06 UTC

FEDORA-2021-3c65d6dc85 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-3c65d6dc85

Comment 9 Fedora Update System 2021-04-07 18:16:36 UTC

FEDORA-2021-3c65d6dc85 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-3c65d6dc85`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-3c65d6dc85

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-04-08 20:57:55 UTC

FEDORA-2021-eecece1e00 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-eecece1e00`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-eecece1e00

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-04-08 21:26:25 UTC

FEDORA-2021-6d80c190a1 has been pushed to the Fedora 32 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-6d80c190a1`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6d80c190a1

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-04-16 14:33:39 UTC

FEDORA-2021-eecece1e00 has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 13 Fedora Update System 2021-04-16 14:42:52 UTC

FEDORA-2021-6d80c190a1 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2021-04-24 19:45:46 UTC

FEDORA-2021-3c65d6dc85 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 15 Fedora Update System 2021-04-24 20:06:04 UTC

FEDORA-2021-3c65d6dc85 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.