Bug 1922503

Summary:	satellite-clone restores postgresql.conf with root:root ownership causing failure to clone
Product:	Red Hat Satellite	Reporter:	Mike McCune <mmccune>
Component:	Satellite Clone	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Vladimír Sedmík <vsedmik>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.7.0	CC:	egolov, ehelms
Target Milestone:	6.11.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-02-03 15:06:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Mike McCune 2021-01-29 22:30:31 UTC

When cloning a 6.7 Satellite server, we perform the following steps:

1) install postgresql server packages:

https://github.com/RedHatSatellite/satellite-clone/blob/81e3be94c5f34887dfe133e9309946a1bd31c175/roles/satellite-clone/tasks/main.yml#L123

2) untar config files:

https://github.com/RedHatSatellite/satellite-clone/blob/81e3be94c5f34887dfe133e9309946a1bd31c175/roles/satellite-clone/tasks/main.yml#L194

3) remove postgresql.conf

https://github.com/RedHatSatellite/satellite-clone/blob/81e3be94c5f34887dfe133e9309946a1bd31c175/roles/satellite-clone/tasks/main.yml#L198

4) run satellite-installer:

https://github.com/RedHatSatellite/satellite-clone/blob/81e3be94c5f34887dfe133e9309946a1bd31c175/roles/satellite-clone/tasks/main.yml#L235


The issue is that satellite-installer does not properly re-set file permissions on postgresql.conf to postgresql:postgresql upon execution of the Puppet code to configure this file, it ends up being root:root as it likely doesn't expect this file to be completely missing.

This causes postgreql server to fail to start and the clone to fail completely.

We need to investigate removing the step (3) above and see if we still need to continue removing this config file as test runs without this step complete properly.

Comment 1 Evgeni Golov 2022-01-28 08:18:45 UTC

This shouldn't be a problem since Foreman 2.4 (so Satellite 6.10+) as that has an updated puppet-postgresql module which contains [1].

This also explains why I was never able to reproduce the error in my tests.

Would you consider this done then?

[1] https://github.com/puppetlabs/puppetlabs-postgresql/commit/171a1be93df8113fce82460d3c9b07f17974af4f

Comment 2 Red Hat Bugzilla 2023-09-15 00:59:37 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days