Bug 1922585

Summary:	The windows oc.exe binary does not have version metadata
Product:	OpenShift Container Platform	Reporter:	OpenShift BugZilla Robot <openshift-bugzilla-robot>
Component:	oc	Assignee:	Maciej Szulik <maszulik>
Status:	CLOSED WONTFIX	QA Contact:	zhou ying <yinzhou>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.4	CC:	aos-bugs, jokerman, mfojtik, yselkowi
Target Milestone:	---	Keywords:	Reopened, UpcomingSprint
Target Release:	4.5.z
Hardware:	x86_64
OS:	Windows
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-03 11:34:06 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1891892
Bug Blocks:

Description OpenShift BugZilla Robot 2021-01-30 11:38:27 UTC

+++ This bug was initially created as a clone of Bug #1891892 +++

+++ This bug was initially created as a clone of Bug #1891555 +++

Created attachment 1724192 [details]
screenshot of the lack of version info on the oc.exe windows binary

Description of problem:
The oc.exe tool for windows does not have version meta-data imbeded in it. This makes automated deployment/management of it very difficult in an enterprise setting.

Version-Release number of selected component (if applicable):

4.4.23

How reproducible:

Every time

Steps to Reproduce:
1. Download windows tools
2. install
3. right click on oc.exe, look in the details tab

Actual results:

file and product version information is blank (see attached screenshot)

Expected results:

file and product version to be populated with data that can be used to Windows software deployment tooling.

Additional info:

--- Additional comment from yselkowi on 2020-10-26 16:20:17 UTC ---

That's what goversioninfo is supposed to be for.  It seems the build infrastructure in origin used to handle that, specifically:

https://github.com/openshift/origin/blob/master/hack/lib/constants.sh#L198-L259
https://github.com/openshift/origin/blob/master/hack/lib/build/binaries.sh#L218-L221
https://github.com/openshift/origin/blob/master/hack/lib/build/binaries.sh#L238-L240

This appears not have been moved over to the separate oc repo when it was split out.

--- Additional comment from maszulik on 2020-11-13 10:55:27 UTC ---

This is waiting in the queue for its turn.

--- Additional comment from maszulik on 2020-12-04 16:20:33 UTC ---

PR in the queue.

--- Additional comment from maszulik on 2021-01-15 11:49:29 UTC ---

PR in the queue.

--- Additional comment from yinzhou on 2021-01-25 02:05:44 UTC ---

Build the oc with the PR , could see the file and product version to be populated with SOURCE_GIT_TAG=4.6.99.

--- Additional comment from yinzhou on 2021-01-25 06:44:49 UTC ---

Created attachment 1750399 [details]
oc detail

Comment 1 Maciej Szulik 2021-02-03 11:31:18 UTC

Based on https://access.redhat.com/support/policy/updates/openshift#dates
the full support for 4.5 has ended. Since this is medium priority fix it
won't be included in 4.5.