Bug 1922799 (golang-github-josephspurrier-goversionin)

New Spec URL: https://eclipseo.fedorapeople.org/for-review/golang-github-josephspurrier-goversioninfo.spec
New SRPM URL: https://eclipseo.fedorapeople.org/for-review/golang-github-josephspurrier-goversioninfo-1.2.0-1.fc34.src.rpm

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.

Moving this to NEW again. I'm in need of this package, and would be happy to co-maintain

Hi,

Since this review is so old, some changes are needed:

- Add the -f flag to %gometa
  New packages should use this to exclude %ix86
- Update to the latest version 1.4.0
- Consider using the rpmautospec macros (%autorelease and %autochangelog)
- Change the %{_bindir}/* to not glob (go2rpm still does this, but it's not recommended):
  https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists
- goversioninfo is an application, shouldn't the package be named goversioninfo instead?
  I'll let you decide, since I don't know the project: https://docs.fedoraproject.org/en-US/packaging-guidelines/Golang/#_source_packages_src_rpm

I'll continue the review after the changes, but I believe it will be ready for approval.

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

This is an automatic action taken by review-stats script.

The ticket reviewer failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we reset the status and the assignee of this ticket.

Hello,
I do realize that this is possibly an old ticket. I am sorry that it hasn't been
reviewed yet. Let me trigger the Fedora Review Service to see if the package
builds successfully. Hopefully, a green check mark will attract some reviewer.

If I am resurrecting an old ticket that you are not interested in anymore, my
apologies, feel free to close it.

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/9816044
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-1922799-golang-github-josephspurrier-goversioninfo/fedora-rawhide-x86_64/09816044-golang-github-josephspurrier-goversioninfo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This is an informal review for practice. The Copr build looks successful and this review contains the necessary files.