Bug 1922969

Summary: python-cherrypy fails to build with Python 3.10: pytest exits with no clear error message
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-cherrypyAssignee: Matthias Runge <mrunge>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: dradez, igor.raits, jcaratza, mhroncok, mrunge, python-sig, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-14 10:35:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1890881    

Description Tomáš Hrnčiar 2021-02-01 08:31:05 UTC
python-cherrypy fails to build with Python 3.10.0a4.

=================================== FAILURES ===================================
____________________________ ParamsTest.test_syntax ____________________________

self = <cherrypy.test.test_params.ParamsTest testMethod=test_syntax>

    def test_syntax(self):
        if sys.version_info < (3,):
            return self.skip('skipped (Python 3 only)')
        code = textwrap.dedent("""
            class Root:
                @cherrypy.expose
                @cherrypy.tools.params()
                def resource(self, limit: int):
                    return type(limit).__name__
            conf = {'/': {'tools.params.on': True}}
            cherrypy.tree.mount(Root(), config=conf)
            """)
        exec(code)
    
        self.getPage('/resource?limit=0')
>       self.assertStatus(200)

Root       = <class 'cherrypy.test.test_params.Root'>
code       = "\nclass Root:\n    @cherrypy.expose\n    @cherrypy.tools.params()\n    def resource(self, limit: int):\n        return type(limit).__name__\nconf = {'/': {'tools.params.on': True}}\ncherrypy.tree.mount(Root(), config=conf)\n"
conf       = {'/': {'tools.params.on': True}}
self       = <cherrypy.test.test_params.ParamsTest testMethod=test_syntax>

cherrypy/test/test_params.py:60: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
/usr/lib/python3.10/site-packages/cheroot/test/webtest.py:327: in assertStatus
    self._handlewebError(msg)
        msg        = 'Status 422 Unprocessable Entity does not match 200'
        self       = <cherrypy.test.test_params.ParamsTest testMethod=test_syntax>
        status     = 200
        tmpl       = 'Status {self.status} does not match {status}'
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <cherrypy.test.test_params.ParamsTest testMethod=test_syntax>
msg = 'Status 422 Unprocessable Entity does not match 200'

    def _handlewebError(self, msg):  # noqa: C901  # FIXME
        print('')
        print('    ERROR: %s' % msg)
    
        if not self.interactive:
>           raise self.failureException(msg)
E           AssertionError: Status 422 Unprocessable Entity does not match 200

msg        = 'Status 422 Unprocessable Entity does not match 200'
self       = <cherrypy.test.test_params.ParamsTest testMethod=test_syntax>

/usr/lib/python3.10/site-packages/cheroot/test/webtest.py:259: AssertionError
----------------------------- Captured stdout call -----------------------------

    ERROR: Status 422 Unprocessable Entity does not match 200

=========================== short test summary info ============================
SKIPPED [1] cherrypy/test/helper.py:321: skipped (not running HTTPS)...
SKIPPED [2] cherrypy/test/test_routes.py:22: Install routes to test RoutesDispatcher code
XPASS cherrypy/test/test_caching.py::CacheTest::test_antistampede #1536
XPASS cherrypy/test/test_conn.py::LimitedRequestQueueTests::test_queue_full #1535
FAILED cherrypy/test/test_params.py::ParamsTest::test_syntax - AssertionError...
= 1 failed, 260 passed, 3 skipped, 1 deselected, 2 xpassed in 80.07s (0:01:20) =
/builddir/build/BUILD/CherryPy-18.6.0/cherrypy/process/wspbus.py:254: RuntimeWarning: The main thread is exiting, but the Bus is in the states.STARTED state; shutting it down automatically now. You must either call bus.block() after start(), or call bus.exit() before the main thread exits.
  warnings.warn(

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01922478-python-cherrypy/

For all our attempts to build python-cherrypy with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-cherrypy/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-02-09 15:44:54 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 2 Miro Hrončok 2021-05-26 14:27:36 UTC
The current error is different, but this makes it build: https://src.fedoraproject.org/rpms/python-cherrypy/pull-request/14

Comment 3 Miro Hrončok 2021-06-04 20:15:13 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 4 Miro Hrončok 2021-06-07 22:59:41 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 5 Miro Hrončok 2021-06-14 10:35:30 UTC
This package was successfully rebuilt with Python 3.10.

If you need this bugzilla open for tracking purposes, sorry for the automatic closing: feel free to reopen it.