Bug 1923722

Summary: Migrations from OCP 3.11 to 4.3 are skipping restore of resources
Product: Migration Toolkit for Containers Reporter: Dylan Murray <dymurray>
Component: VeleroAssignee: Dylan Murray <dymurray>
Status: CLOSED ERRATA QA Contact: Xin jiang <xjiang>
Severity: unspecified Docs Contact: Avital Pinnick <apinnick>
Priority: unspecified    
Version: 1.4.0CC: chezhang, ernelson, rjohnson, sregidor, whu
Target Milestone: ---   
Target Release: 1.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1946787 (view as bug list) Environment:
Last Closed: 2021-02-11 12:55:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1946787, 1967764    

Description Dylan Murray 2021-02-01 17:44:59 UTC 
Description of problem:
This is a regression and a duplicate of https://bugzilla.redhat.com/show_bug.cgi?id=1886125.

Essentially, the imagetag plugin in the openshift velero plugin is being applied to all resources in 4.3 and below due to the imagetag CRD not existing in the cluster.

Version-Release number of selected component (if applicable):
MTC 1.4

How reproducible:
100%

Steps to Reproduce:
1. Migrate from OCP 3.11 to OCP 4.3


Actual results:
In the velero pod on the destination cluster the logs show every resources is being discarded by the imagetag plugin.

Expected results:
Migration succeeds.

Additional info:
The actual issue is an upstream bug where if a plugin is registered with Velero and the associated CRD doesn't exist, every resource matches the plugin. This may or may not be resolved upstream in Velero yet I need to dig further. For 1.4.0 we will simply remove the imagetag plugin from the openshift plugin as we did for 1.3.
Comment 1 Dylan Murray 2021-02-01 19:28:59 UTC 
https://github.com/konveyor/openshift-velero-plugin/pull/70
Comment 6 Sergio 2021-02-03 14:54:38 UTC 
Verified using: 
- MTC 1.4.0
- 3.11 -> 4.3 AWS, AWS S3
- 4.5 -> 4.7 AWS, AWS S3

openshift-migration-rhel7-operator@sha256:085a42a4bdf32cd0ae12cb5af17d6ee6274a577a67298708a2eff3220e08fc23
    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: 5590dc251338f1d909bb6c76722d251c5de114c272d6425455549623a5472c4d


Moved to VERIFIED status.
Comment 8 errata-xmlrpc 2021-02-11 12:55:27 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) tool image release advisory 1.4.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:5329