Bug 1923999

Even with correct setting, NetworkManager still complains:

sysctl: failed to set 'bonding/ad_actor_system' to '00:00:00:00:00:00': (22) Invalid argument


Reproducer:

 * sudo nmcli c add type bond connection.id bond0 ifname bond0 ipv4.method disabled ipv6.method disabled
 * sudo journalctl  -t NetworkManager  --since -1m -p 3


Meanwhile, this is just a no harming error message. If possible, please suggest customer to ignore it before our fix.
Changing to NetworkManager component.

The error message is harmless, the value(00:00:00:00:00:00) is already the default value in kernel.
The kernel is in the state we requested, NetworkManager just showing the wrong message.

Created attachment 1758781 [details]
System logs with NM trace enabled

(In reply to Gris Ge from comment #12)
>  * sudo nmcli c add type bond connection.id bond0 ifname bond0 ipv4.method
> disabled ipv6.method disabled

It needs:

   nmcli c add type bond connection.id bond0 ifname bond0 ipv4.method disabled ipv6.method disabled bond.options 'mode=802.3ad'



But this seems more of a kernel issue:


    ip link add name bond1 type bond

    cat /sys/class/net/bond1/bonding/ad_actor_system
    # no output

    echo 802.3ad > /sys/class/net/bond1/bonding/mode 
    cat /sys/class/net/bond1/bonding/ad_actor_system
    # output 00:00:00:00:00:00

    echo 00:00:00:00:00:00 > /sys/class/net/bond1/bonding/ad_actor_system
    # -bash: echo: write error: Invalid argument

    echo 00:00:00:00:00:01 > /sys/class/net/bond1/bonding/ad_actor_system
    cat /sys/class/net/bond1/bonding/ad_actor_system
    # output 00:00:00:00:00:01

    echo 00:00:00:00:00:00 > /sys/class/net/bond1/bonding/ad_actor_system
    # -bash: echo: write error: Invalid argument



Meaning: with 802.3ad, the default value is 00:00:00:00:00:00, and kernel doc even says: "If the value is not given then system defaults to using the masters' mac address as actors' system address.".
But setting 00:00:00:00:00:00 via sysfs is always rejected with EINVAL.

That means,

  - you cannot set the current value (setting the value that is currently set, should not be an error)

  - after setting a different MAC address, you cannot reset the default value.

Fixed upstream by https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/commit/9e7af314546d7912ee23b3850230008902aca4d3 .

Note that this *only* avoids a warning in the logfile. Otherwise, there is no change (as there was no bug in NetworkManager).


I think this is a kernel issue however. I reported bug 1931881 for that.

It's not very severe, since it only happens if you want to change ad_actor_system back to "00:00:00:00:00:00". Both via `nmcli device reapply` or by activating a profile on an existing bond interface.

Nirav,
Can you please ensure we have a KCS about this stating that with 8.3 the bond issue is resolved and the message itself is harmless, as explained above?
Since I see we started getting more cases on it.

slight modification to catch the error added to NMCI:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager-ci/-/commit/eaecfae8b8963e91ac83b7a5000e6cd4b2b82957

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: NetworkManager and libnma security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:1574