Bug 1924236

Summary:	NFD Operator is failing to update and remains in Replacing state
Product:	OpenShift Container Platform	Reporter:	Carlos Eduardo Arango Gutierrez <carangog>
Component:	Node Feature Discovery Operator	Assignee:	Carlos Eduardo Arango Gutierrez <carangog>
Status:	CLOSED ERRATA	QA Contact:	Walid A. <wabouham>
Severity:	high	Docs Contact:
Priority:	high
Version:	4.5	CC:	carangog, mifiedle, sejug, sreber, wabouham
Target Milestone:	---
Target Release:	4.5.z
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:	1924232	Environment:
Last Closed:	2021-03-03 04:32:28 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1924232
Bug Blocks:

Comment 3 Walid A. 2021-02-23 20:19:10 UTC

Verified by installing an OCP 4.5.32 cluster in AWS.  Deployed NFD from Operator hub with CSV nfd.4.5.0-202102200202.p0.

Upgrade OCP to version 4.6.18.
After upgrading OCP, from OCP console, Operators -> Installed Operator ->  NFD operator, clicked on Subscription, clicked on channel, I could see the 4.6 CSV nfd.4.6.0-202102130032.p0.  (upgrade strategy Automatic).  Selected the 4.6 CSV.  This resulted in the 4.5 NFD operator terminating and new 4.6 NFD operator starting out, with nfd-master and nfd-worker pods terminating then being recreated from the newer 4.6 images.  NFD labels also got updated to refelct the new version 4.6.18.

Events from namespace where NFD operator was deployed showed:

45m         Normal    BeingReplaced         clusterserviceversion/nfd.4.5.0-202102200202.p0   being replaced by csv: nfd.4.6.0-202102130032.p0
45m         Normal    Replaced              clusterserviceversion/nfd.4.5.0-202102200202.p0   has been replaced by a newer ClusterServiceVersion that has successfully installed.
45m         Normal    RequirementsUnknown   clusterserviceversion/nfd.4.6.0-202102130032.p0   requirements not yet checked
45m         Normal    AllRequirementsMet    clusterserviceversion/nfd.4.6.0-202102130032.p0   all requirements found, attempting install
45m         Normal    InstallSucceeded      clusterserviceversion/nfd.4.6.0-202102130032.p0   waiting for install components to report healthy
45m         Normal    InstallWaiting        clusterserviceversion/nfd.4.6.0-202102130032.p0   installing: waiting for deployment nfd-operator to become ready: Waiting for deployment spec update to be observed...
45m         Normal    InstallWaiting        clusterserviceversion/nfd.4.6.0-202102130032.p0   installing: waiting for deployment nfd-operator to become ready: Waiting for rollout to finish: 1 old replicas are pending termination...
45m         Normal    InstallSucceeded      clusterserviceversion/nfd.4.6.0-202102130032.p0   install strategy completed with no errors


# oc get csv -n test-nfd
NAME                                           DISPLAY                  VERSION                 REPLACES                    PHASE
elasticsearch-operator.4.5.0-202102200202.p0   Elasticsearch Operator   4.5.0-202102200202.p0                               Succeeded
nfd.4.6.0-202102130032.p0                      Node Feature Discovery   4.6.0-202102130032.p0   nfd.4.5.0-202102200202.p0   Succeeded

# oc get pods -n test-nfd
NAME                            READY   STATUS    RESTARTS   AGE
nfd-master-6ksbb                1/1     Running   0          53m
nfd-master-b5w9n                1/1     Running   0          53m
nfd-master-x9z9j                1/1     Running   0          53m
nfd-operator-64c59fbdc9-c85sc   1/1     Running   0          54m
nfd-worker-7qcf4                1/1     Running   0          53m
nfd-worker-j2p4v                1/1     Running   0          54m
nfd-worker-zdd5w                1/1     Running   0          53m

Comment 5 errata-xmlrpc 2021-03-03 04:32:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.5.33 extras update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:0430