Bug 1924705

Summary:	[incremental backup] python3-libvirt is missing newly added constants for incremental backup
Product:	Red Hat Enterprise Linux Advanced Virtualization	Reporter:	Eyal Shenitzky <eshenitz>
Component:	libvirt-python	Assignee:	Peter Krempa <pkrempa>
Status:	CLOSED ERRATA	QA Contact:	chunfu wen <chwen>
Severity:	high	Docs Contact:
Priority:	urgent
Version:	8.3	CC:	chhu, ddepaula, dyuan, jdenemar, jinzhao, jsuchane, lmen, pkrempa, smitterl, virt-maint, xuzhang, ymankad
Target Milestone:	rc
Target Release:	8.4
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvirt-python-6.6.0-2.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-22 15:39:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eyal Shenitzky 2021-02-03 13:39:54 UTC

Description of problem:

The latest python3-libvirt-6.6.0-1 is missing several flags that are needed for incremental backup in RHV - 
VIR_DOMAIN_CHECKPOINT_CREATE_REDEFINE_VALIDATE, VIR_ERR_CHECKPOINT_INCONSISTENT.

python3-libvirt should be rebuilt and contain the flags above.

Version-Release number of selected component (if applicable):
python3-libvirt-6.6.0-1

How reproducible:

Steps to Reproduce:
1.
2.
3.

Actual results:
python3-libvirt-6.6.0-1 missing the mentioned flags


Expected results:
python3-libvirt should include the above flags/constants.


Additional info:

Comment 1 Peter Krempa 2021-02-03 13:44:28 UTC

The package needs to be rebuilt to pick up the new constants. Moving to POST.

Comment 11 chhu 2021-02-05 01:47:42 UTC

Thanks Eyal very much for helping test the incremental backup on RHV for libvirt-python-6.6.0-2.el8 !
Please see Eyal's test results as below:
-----------------------------------------------------------------------
After installing python3-libvirt-6.6.0-2 from the attached RPM [1] 

All the missing constants can be found:

 $ python3
Python 3.6.8 (default, Aug 18 2020, 08:33:21)
[GCC 8.3.1 20191121 (Red Hat 8.3.1-5)] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import libvirt
>>> hasattr(libvirt, "VIR_ERR_CHECKPOINT_INCONSISTENT")
True

Also, the relevant cold incremental backup feature that uses those flags worked as expected.

[1] http://download.eng.bos.redhat.com/brewroot/vol/rhel-8/packages/libvirt-python/6.6.0/2.module+el8.3.1+9800+33087bb5/x86_64/python3-libvirt-6.6.0-2.module+el8.3.1+9800+33087bb5.x86_64.rpm

Comment 14 errata-xmlrpc 2021-02-22 15:39:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:0639