Bug 1925223

Summary:	Review Request: R-cachem - Cache R Objects with Automatic Pruning
Product:	[Fedora] Fedora	Reporter:	Tom "spot" Callaway <spotrh>
Component:	Package Review	Assignee:	José Matos <jamatos>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jamatos, package-review
Target Milestone:	---	Flags:	jamatos: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-08 20:49:43 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Tom "spot" Callaway 2021-02-04 16:09:32 UTC

Spec URL: https://spot.fedorapeople.org/R-cachem.spec
SRPM URL: https://spot.fedorapeople.org/R-cachem-1.0.2-1.fc33.src.rpm
Description: Key-value stores with automatic pruning. Caches can limit either their total size or the age of the oldest object (or both), automatically pruning objects to maintain the constraints.
Fedora Account System Username: spot

Comment 1 Tom "spot" Callaway 2021-02-04 16:10:31 UTC

Needed to update R-memoise

Comment 2 José Matos 2021-02-04 21:54:40 UTC

The license is correct and appropriated for Fedora.
The spec file is simple and correct.

fedora-review complains:
- Package have the default element marked as %%doc :DESCRIPTION
- Package requires R-core.
- If (and only if) the source package includes the text of the license(s)
  in its own file, then that file, containing the text of the license(s)
  for the package is included in %license.
  Note: License file LICENSE is not marked as %license
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/LicensingGuidelines/#_license_text

The last one can also be ignored since the file LICENSE it is not a license. :-)

Recycling from a previous review "After reviewing so many packages the other thing that shows up is that probably the %install section could get a macro on R-rpm-macros since this chunk appears so many times:

mkdir -p %{buildroot}%{rlibdir}
%{_bindir}/R CMD INSTALL -l %{buildroot}%{rlibdir} %{packname}
test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so)
rm -f %{buildroot}%{rlibdir}/R.css
"

In this case the chunk is similar:
mkdir -p $RPM_BUILD_ROOT%{_libdir}/R/library
%{_bindir}/R CMD INSTALL -l $RPM_BUILD_ROOT%{_libdir}/R/library %{packname}
test -d %{packname}/src && (cd %{packname}/src; rm -f *.o *.so)
rm -rf $RPM_BUILD_ROOT%{_libdir}/R/library/R.css

I should probably submit a patch to R-rpm-macros since this is tedious and repetitive. :-)

The package is approved.

Comment 3 Mohan Boddu 2021-02-08 16:42:52 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/R-cachem

Comment 4 Tom "spot" Callaway 2021-02-08 20:49:43 UTC

In rawhide.