Bug 1925358

Summary:	Restic pod does not restart during IDVM migration from OCP 3.9
Product:	Migration Toolkit for Containers	Reporter:	whu
Component:	Controller	Assignee:	Pranav Gaikwad <pgaikwad>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	medium	Docs Contact:	Avital Pinnick <apinnick>
Priority:	medium
Version:	1.4.0	CC:	ernelson, pgaikwad, rjohnson, sregidor, whu, xjiang
Target Milestone:	---
Target Release:	1.4.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-15 08:15:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description whu 2021-02-05 01:50:00 UTC

Description of problem:
Run a common indirect volume migration from ocp3.9 to ocp 4.7 cluster, the restic pod did not restart during migration. But the restic pods should be restarted. 

Version-Release number of selected component (if applicable):
MTC 1.4.0
image: registry.redhat.io/rhmtc/openshift-migration-rhel7-operator@sha256:085a42a4bdf32cd0ae12cb5af17d6ee6274a577a67298708a2eff3220e08fc23
source cluster: AWS OCP 3.9
target cluster: AWS OCP 4.7  (controller)

How reproducible:
Always

Steps to Reproduce:
1. create a common application in source cluster, such like nginx
oc process -p LOGS_ACCESSMODE=ReadWriteOnce  -p LOGS_STORAGECLASS=gp2  -p HTML_ACCESSMODE=ReadWriteOnce  -p HTML_STORAGECLASS=gp2 -p namespace=ocp-22222-nginx -f https://gitlab.cee.redhat.com/app-mig/cam-helper/raw/master/ocp-24706/nginx_with_pv_template.yml  | oc create -f -
2. create migplan as nornal with indrect volume migration mode
3. trigger migration

Actual results:
The restic pod did not restart during migration

Expected results:
The restic pod should be restarted during migration

Additional info:
$ oc get migcluster source-cluster -o yaml
spec:
  exposedRegistryPath: docker-registry-default.apps.0203-cok.qe.rhcloud.com
  insecure: true
  isHostCluster: false
  serviceAccountSecretRef:
    name: sa-token-source-cluster
    namespace: openshift-migration
  url: https://ec2-34-235-121-235.compute-1.amazonaws.com:8443

Comment 2 Pranav Gaikwad 2021-02-25 18:31:12 UTC

I confirmed that the Restic Pods are not being restarted on OpenShift 3.7 & 3.9

This is due to a regression introduced in 1.4.0 when we added Velero stale backup/restore cleanup logic. I have tested a fix to resolve this issue but I'd like to confirm with Derek (he originally worked on Velero cleanup) that my change doesn't affect any of the new logic thats in place for removing stale Velero state.

Comment 7 Sergio 2021-03-05 16:17:48 UTC

Verified using MTC 1.4.2

openshift-migration-rhel7-operator@sha256:7ef3e0373302290880469269d34b8caa771d420848ed448a8b11280416328669
    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: f02f9a62479b9ec712c622880128a80dafb5e034a97df6c34fc14cf0c0699f21

Run test case ocp-31355-restartrestic-37-39

Moved to VERIFIED status.

Comment 11 errata-xmlrpc 2021-03-15 08:15:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) image release advisory 1.4.2), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:0814