Bug 1925532

Description of problem:
----------------------


The Satellite RPM depends on puppet-foreman_scap_client. This module has also a Facts that are ALLWAYS synced to the ALL Client even that i do not use the foramn_scap_client.


-----------
Dependencies Resolved

======================================================================================================================
 Package                         Arch        Version               Repository                                    Size
======================================================================================================================
Removing:
 puppet-foreman_scap_client      noarch      0.4.0-1.el7sat        @local-rhel-7-server-satellite-6.8-rpms       58 k
Removing for dependencies:
 satellite                       noarch      6.8.3-1.el7sat        @local-rhel-7-server-satellite-6.8-rpms       72

Transaction Summary
======================================================================================================================
Remove  1 Package (+1 Dependent package)

Installed size: 58 k
Is this ok [y/N]: n
-----------

---------
[crash/LI] root@li-lc-2224:~# cat /usr/share/puppet/modules/foreman_scap_client/lib/facter/rh_certificates.rb
def extract_certificates_from_subscription_manager
  certificates = {}
  certificate_end_path = '/cert.pem'
  private_key_end_path = '/key.pem'
  rh_default_ca_cert = '/etc/rhsm/ca/redhat-uep.pem'
  data = Facter::Util::Resolution.exec('/usr/sbin/subscription-manager config')
  return nil if data.nil? || data.empty?
  data = data.gsub("\n", "").gsub(/[\[\]]/, "")
  data_array = data.scan(/(\S+)\s*=\s* ([^ ]+)/)
  data_hash = Hash[*data_array.flatten]
  consumer_cert_dir = data_hash["consumercertdir"]
  certificates[:repo_ca_cert]          = data_hash["repo_ca_cert"] unless data_hash["repo_ca_cert"] == rh_default_ca_cert
  certificates[:host_certificate_path] = consumer_cert_dir + certificate_end_path
  certificates[:host_private_key_path] = consumer_cert_dir + private_key_end_path

  certificates
end

certificates_hash = extract_certificates_from_subscription_manager
# Set Katello certificates only if certificates_hash[:repo_ca_cert] exists
if certificates_hash && certificates_hash[:repo_ca_cert]
  Facter.add('rh_certificate_repo_ca_file') do
    setcode do
      certificates_hash[:repo_ca_cert]
    end
  end

  Facter.add('rh_certificate_consumer_host_cert') do
    setcode do
      certificates_hash[:host_certificate_path]
    end
  end

  Facter.add('rh_certificate_consumer_host_key') do
    setcode do
      certificates_hash[:host_private_key_path]
    end
  end
end
[crash/LI] root@li-lc-2224:~#
----------

Effect on the Client:
----------
vrempet-admin@li-lc-1437 ~
$ sudo facter -p | grep rh_
rh_certificate_consumer_host_cert => /etc/pki/consumer/cert.pem
rh_certificate_consumer_host_key => /etc/pki/consumer/key.pem
rh_certificate_repo_ca_file => /etc/rhsm/ca/katello-server-ca.pem

vrempet-admin@li-lc-1437 ~
$
----------


Version-Release number of selected component (if applicable):
------------------------------------------------------------

Satellite Server 6.8


Expected results:
----------------

1. Please give the Customer control over the Puppet Modules and Facts.

2. Please remove this RPM dependency from the top-level 'satellite' rpm so i can uninstall rpms that provide Puppet Modules that i am not using.