Bug 1925553

Summary:	Requesting MigAnalytic information from a "not ready" MigPlan breaks the analytic screen for all MigPlans
Product:	Migration Toolkit for Containers	Reporter:	Sergio <sregidor>
Component:	General	Assignee:	Ian <ibolton>
Status:	CLOSED ERRATA	QA Contact:	Xin jiang <xjiang>
Severity:	medium	Docs Contact:	Avital Pinnick <apinnick>
Priority:	medium
Version:	1.4.0	CC:	chezhang, ernelson, rjohnson, rpattath, whu, xjiang
Target Milestone:	---
Target Release:	1.4.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-15 08:15:36 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sergio 2021-02-05 14:36:41 UTC

Description of problem:
When we ask for the analytic information of a migplan that is not ready, the analytic screens of the rest of the migplans stop working.

Version-Release number of selected component (if applicable):
MTC 1.4.0

How reproducible:
Always

Steps to Reproduce:
1. Configure the "Exposed route to image registry" in the source cluster, so that we can create Direct Image Migration migplans.

2. Deploy an application in a namespace

oc new-project direct-django-notready
oc new-app django-psql-persistent

3. Deploy another application in another namespace

oc new-project indirect-django-ready
oc new-app django-psql-persistent

4. Create a Direct Image Migration migplan for the namespace created in step 2 "direct-django-notready"

5. Create an Indirect Image Migration migplan for the namespace created in step 3 "indirect-django-ready"

At this point we will have 2 ready migplans
$ oc get migplan
NAME READY SOURCE TARGET STORAGE AGE
direct-django-notready True source-cluster host automatic 52s
indirect-django-ready True source-cluster host automatic 21s

6. Remove the "Exposed route to image registry" from the source cluster. It will set the "direct-django-notready" migplan in "not ready" status.

Now we have one migplan ready, and one migplan not ready
$ oc get migplan
NAME READY SOURCE TARGET STORAGE AGE
direct-django-notready source-cluster host automatic 2m50s
indirect-django-ready True source-cluster host automatic 2m19s

7. Click on "direct-django-notready" migplan "Namespaces", and click on "Refresh".

The page will be stuck with an infinte spinner. This will be the resulting miganalytics in the CLI
$ oc get miganalytic
NAME READY PLAN PROGRESS RESOURCES IMAGES IMAGESIZE PVS PVCAPACITY AGE
direct-django-notready direct-django-notready 0 0 0 0 0 0 80s
indirect-django-ready True indirect-django-ready 100 42 1 227Mi 1 1Gi 5m22s

8. Now click on "indirect-django-ready" migplan "Namespaces", and click on "Refresh".

Again the page will be stuck with an infinte spinner.

Actual results:
After asking for the miganalytic of a migration plan in "not ready" status, all analytic screens of all the migplans are stuck with an endless spinner.

Expected results:
We should tell the user that we cannot compute the analytic of a not ready migplan instead of showing an endless spinner. Maybe the "Refresh" button should be disabled in "not ready" migplans.

We should be able to work normally with "Ready" migplans analytic, even if there are problems with other migplans analytic.

Additional info:
If we delete the miganalytic of the "not ready" plan everything starts behaving normally again.

Comment 4 Sergio 2021-03-08 12:04:09 UTC

Verified using MTC 1.4.2

openshift-migration-rhel7-operator@sha256:20cb66a4cc32bd51c111afda54461af5c2834fe0fccc93baed6134e8cbafc480

The UI will show this message now when we request analytics for a not-ready migplan

"The Migration plan is not in a ready state."

If we try to create the analytic manually we get this warning in the miganalytic resource:

    - category: Critical
      lastTransitionTime: "2021-03-08T11:59:50Z"
      message: Waiting 10 seconds for referenced MigPlan to become ready.
      reason: TestFailed
      status: "True"
      type: Postponed


Plus, the ready plan's analytics are not blocked any more.


Moved to verified.

Comment 8 errata-xmlrpc 2021-03-15 08:15:36 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) image release advisory 1.4.2), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:0814