Bug 1925758

Summary:	Review Request: python-rstr - Generate random strings in Python
Product:	[Fedora] Fedora	Reporter:	Frédéric Pierret <frederic.pierret>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-14 16:42:38 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Frédéric Pierret 2021-02-06 09:13:50 UTC

Following the review of reprotest (https://bugzilla.redhat.com/show_bug.cgi?id=1924918) and its dependencies, I open a separate ticket for python-rstr:

- Description: Generate random strings in Python
- GIT: https://github.com/fepitre/fedora-python-rstr
- SPEC: https://raw.githubusercontent.com/fepitre/fedora-python-rstr/master/python-rstr.spec
- SRPM: https://download.copr.fedorainfracloud.org/results/fepitre/fedora/fedora-rawhide-x86_64/01945419-python-rstr/python-rstr-2.2.6-1.fc34.src.rpm

With respect to the original version provided in https://bugzilla.redhat.com/show_bug.cgi?id=1924918, I've took into account the review comments and updated the spec and rebuilt the package.

Comment 1 Zbigniew Jędrzejewski-Szmek 2021-02-09 08:47:22 UTC

> http://bitbucket.org/leapfrogdevelopment/rstr/overview

No https? Returns 404.

+ package name is OK
+ license is acceptable for Fedora (BSD)
+ license is specified correctly
+ builds and installs OK
+ R/BR/P look OK
+ fedora-review finds no issues

rpmlint:
python3-rstr.noarch: W: invalid-url URL: http://bitbucket.org/leapfrogdevelopment/rstr/overview HTTP Error 404: Not Found
python3-rstr.noarch: W: no-documentation
1 packages and 0 specfiles checked; 0 errors, 2 warnings.

Package is APPROVED.

Comment 2 Frédéric Pierret 2021-02-09 16:27:28 UTC

Thank you again for your review and now your approval for this one. I've changed URL to baseurl https://files.pythonhosted.org where the original URL redirects to.

Comment 3 Mohan Boddu 2021-02-12 14:41:10 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rstr

Comment 4 Frédéric Pierret 2021-02-14 16:42:38 UTC

Package is built in rawhide. Closing it. Thank you for all.