Bug 192603
Summary: | Review Request: openalpp - Object Oriented version of OpenAL | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christopher Stone <chris.stone> |
Component: | Package Review | Assignee: | Hans de Goede <hdegoede> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2006-06-01 22:40:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 163779 |
Description
Christopher Stone
2006-05-21 20:06:08 UTC
Claiming this one before Mike (wart) does it, so that I actually get a chance to give some reviews back for all the reviews you have been doing for me :) Dunno when I have the time todo the actual review though, might take a couple of days (but no longer). MUST: ===== * rpmlint output is: W: openalpp-devel no-documentation No problem here. * Package and spec file named appropriately * Packaged according to packaging guidelines * License (LGPL) ok, license file included * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel-i386 * BR: ok * No locales * ldconfig properly called for shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * proper -devel package needed * .la files not packaged * no gui -> no .desktop file required MUST fix: ========= * Group: for the base package is wrong it should be: "System Environment/Libraries" Should fix: =========== * Why patch 3330 ??? Spec URL: http://tkmame.retrogames.com/fedora-extras/openalpp.spec SRPM URL: http://tkmame.retrogames.com/fedora-extras/openalpp-20060405-3.src.rpm %changelog * Tue May 30 2006 Christopher Stone <chris.stone> 20060405-3 - Fix Group - Fix patch number The debian guys added that patch to the spec file, I'm not sure why they chose 3330, I've changed it back to just patch0. Group has also been fixed. Thanks for the review! I'm not sure if you noticed, but I did approve the xgalaga package a week ago. All problems fixed -> approved!
> I'm not sure if you noticed, but I did approve the xgalaga package a week ago.
No I didn't notice, this must have fallen through the cracks, thanks for the
headsup.
|