Bug 192611

Summary:	xvattr: $RPM_OPT_FLAGS not honored
Product:	[Fedora] Fedora	Reporter:	Ville Skyttä <scop>
Component:	xvattr	Assignee:	Matthias Saou <matthias>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	extras-qa
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	1.3-10	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-05-23 09:23:02 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ville Skyttä 2006-05-21 21:36:01 UTC

xvattr's build doesn't appear to be honoring $RPM_OPT_FLAGS, reusulting in
compiler security features not being used and a more or less useless debuginfo
package.  More info: http://fedoraproject.org/wiki/Packaging/Debuginfo

Possible fix, in %prep:
sed -i -e 's/^\(CFLAGS\s*=.*\)/\1 $(RPM_OPT_FLAGS)/' Makefile*

Comment 1 Matthias Saou 2006-05-23 09:23:02 UTC

I don't like exposing RPM_OPT_FLAGS inside generic sources, so I've done this
instead (same result of course) :

# Append GTK CFLAGS to CFLAGS instead of overwriting CFLAGS (optflags get used)
%{__perl} -pi -e 's|^CFLAGS = (.*)|CFLAGS += $1|g' Makefile*

Packages for FC-4, FC-5 and devel will be rebuilt now.