Bug 1926119

Summary: Preallocation typo on DV' PVC annotations
Product: Container Native Virtualization (CNV) Reporter: Qixuan Wang <qixuan.wang>
Component: StorageAssignee: Tomasz BaraƄski <tbaransk>
Status: CLOSED ERRATA QA Contact: Qixuan Wang <qixuan.wang>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 2.6.0CC: alitke, cnv-qe-bugs, mrashish, ngavrilo, yadu, ycui
Target Milestone: ---   
Target Release: 2.6.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: virt-cdi-importer v2.6.1-3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-04-07 08:46:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Qixuan Wang 2021-02-08 09:29:55 UTC
Description of problem:
Typo: preallocation on DV's PVC annotations

cdi.kubevirt.io/storage.preallocacation.requested -> cdi.kubevirt.io/storage.preallocation.requested


Version-Release number of selected component (if applicable):
Containerized Data Importer v1.28.2


How reproducible:
100%


Steps to Reproduce:
1. Create a DV yaml and preallocation (see below).

$ cat preallocated-dv.yaml
apiVersion: cdi.kubevirt.io/v1beta1 
kind: DataVolume
metadata:
  name: preallocated-dv
spec:
  source:
    http:
      url: "http://xxx/rhel-82.qcow2"
  pvc:
    accessModes:
      - ReadWriteOnce
    resources:
      requests:
        storage: 5Gi
    storageClassName: hostpath-provisioner
  preallocation: true

2. Check PVC 
$ oc get pvc -o yaml | grep pre


Actual results:
[cnv-qe-jenkins@stg05-qixuan-b59vp-executor ~]$ oc get pvc -o yaml | grep pre

      cdi.kubevirt.io/storage.preallocacation.requested: "true"
      cdi.kubevirt.io/storage.preallocation: "true"


Expected results:
[cnv-qe-jenkins@stg05-qixuan-b59vp-executor ~]$ oc get pvc -o yaml | grep pre

      cdi.kubevirt.io/storage.preallocation.requested: "true"
      cdi.kubevirt.io/storage.preallocation: "true"


Additional info:

Comment 1 Adam Litke 2021-02-18 21:28:41 UTC
Moving back to ASSIGNED.  Tomasz, please prepare a backport PR and link it to the BZ.  You can then move the bug back to POST.  Thanks.

Comment 2 Maya Rashish 2021-03-16 10:50:38 UTC
Hasn't made its way to downstream builds yet (although it would normally be reasonable to expect it to have made it there by now - it got stuck on some midstream issue)

Comment 3 Qixuan Wang 2021-03-18 08:55:37 UTC
The latest QE cluster uses Containerized Data Importer v1.28.3-9-g1f74571, which is d/s v2.6.1-2. Wait for a v2.6.1-3 cluster.

Comment 4 Qixuan Wang 2021-03-24 05:07:44 UTC
Tested with CDI D/S v2.6.1-4 (U/S v1.28.3-11-g294de77), the bug has been fixed, thanks.

[cnv-qe-jenkins@stg05-qixuan-wm27v-executor ~]$ oc get pvc preallocated-dv -o yaml | grep pre
    cdi.kubevirt.io/storage.import.importPodName: importer-preallocated-dv
    cdi.kubevirt.io/storage.preallocation.requested: "true"
          f:cdi.kubevirt.io/storage.preallocation.requested: {}
[...]

Comment 9 errata-xmlrpc 2021-04-07 08:46:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (CNV 2.6.1 Images), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:1126