Bug 1926888

Summary: [RFE][CBT] Allow mixed incremental backup of RAW and COW disks
Product: [oVirt] ovirt-engine Reporter: Yury.Panchenko
Component: Backup-Restore.VMsAssignee: Eyal Shenitzky <eshenitz>
Status: CLOSED CURRENTRELEASE QA Contact: Ilan Zuckerman <izuckerm>
Severity: high Docs Contact: bugs <bugs>
Priority: unspecified    
Version: 4.4.3.12CC: ahadas, asharir, bugs, dfodor, didi, eshenitz, nsoffer, pchavva, sfishbai, tnisan, Yury.Panchenko
Target Milestone: ovirt-4.4.5Keywords: FutureFeature
Target Release: ---Flags: asharir: testing_plan_complete+
pm-rhel: planning_ack?
pm-rhel: devel_ack?
pm-rhel: testing_ack?
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Feature: VM backup that contains both full backups for part of the disks and incremental backups for the others is now allowed. Reason: A mixed backup will allow the creation of a backup for the VM under a single operation. Before that, the user had to do an incremental backup for the disks that already had a backup and supports it and a different full backup for the disks that are not marked as 'Incremental backup enabled'. Result: Full and incremental backup can be taken in the same backup operation under the same checkpoint. the backup_mode of each disk in the backup will indicate the type of backup that was taken for each disk (full/incremental).
 Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-18 15:14:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Storage RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yury.Panchenko 2021-02-09 15:47:12 UTC 
Description of problem:
The incremental backup can start with only one checkpoint id for all disks in a vm. If vm has a new disk or combination of QCOW and RAW disks, we can’t continue the current incremental backup. For the case of added disk, we start a new incremental backup flow. And for the case of the disk combination (RAW + QCOW) we can use only the full backup.

This limitation creates an additional data size in the restore points. 

Version-Release number of selected component (if applicable):
ovirt-4.4.3

How reproducible:
Create a vm with QCOW and RAW disk. Start incremental backup.

Actual results:
Incremental backup fails.

Expected results:
QCOW disk backups in the incremental mode, RAW disk makes the full backup.
Comment 1 Yury.Panchenko 2021-02-11 18:25:02 UTC 
Hello, Eyal.
Don't forget to provide compatibility with the current variant of usage, please.
Comment 2 Eyal Shenitzky 2021-02-14 08:29:13 UTC 
(In reply to Yury.Panchenko from comment #1)
> Hello, Eyal.
> Don't forget to provide compatibility with the current variant of usage,
> please.

Hi Yury,

Sure, we do not break the previous implementation.
Comment 3 Ilan Zuckerman 2021-03-08 13:52:46 UTC 
Verified on rhv-release-4.4.5-7-001.noarch

- Clone VM from template (so it would have thin OS disk)
- Add new preallocated disk to the VM
- Initiate full backup on both disks
- Initiate incremental backup on both disks

Repeat this flow with stopped / started VM

Expected:
OS disk (thin) should have incremental backup_mode [1]
Data disk (preallocated) should have full backup_mode

Actual: As expected

[1]:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<disks>
    <disk id="7e8a33df-bd77-43c0-8518-d277be8ac8c4">
        <name>latest-rhel-guest-image-8.3-infra</name>
        <description>latest-rhel-guest-image-8.3-infra (c5705fc)</description>
        <actual_size>46526464</actual_size>
        <alias>latest-rhel-guest-image-8.3-infra</alias>
        <backup>none</backup>
        <backup_mode>incremental</backup_mode>
        <content_type>data</content_type>
        <format>cow</format>
        <image_id>2883d8e3-4336-44a4-b52d-ab011fbe676d</image_id>
        <propagate_errors>false</propagate_errors>
        <provisioned_size>10737418240</provisioned_size>
        <qcow_version>qcow2_v3</qcow_version>
        <shareable>false</shareable>
        <sparse>true</sparse>
        <status>locked</status>
        <storage_type>image</storage_type>
        <total_size>0</total_size>
        <wipe_after_delete>false</wipe_after_delete>
        <disk_profile id="ba2d4ca8-1c08-479b-9b04-b04f19455506"/>
        <quota id="5467fe9e-163b-4dce-9c04-329aa3ee0c41">
            <data_center id="0023a401-1695-4c42-aa61-2f7108c0ccb8"/>
        </quota>
        <storage_domains>
            <storage_domain id="800404de-67cb-4321-a64b-b083a43967e3"/>
        </storage_domains>
    </disk>
    <disk id="c0e6fb33-b753-4cca-825b-9177b4a568db">
        <name>26779_Disk1</name>
        <description></description>
        <actual_size>1073741824</actual_size>
        <alias>26779_Disk1</alias>
        <backup>none</backup>
        <backup_mode>full</backup_mode>
        <content_type>data</content_type>
        <format>raw</format>
        <image_id>28f728a8-ee9e-41c1-9750-655073bc70fc</image_id>
        <propagate_errors>false</propagate_errors>
        <provisioned_size>1073741824</provisioned_size>
        <shareable>false</shareable>
        <sparse>false</sparse>
        <status>locked</status>
        <storage_type>image</storage_type>
        <total_size>0</total_size>
        <wipe_after_delete>false</wipe_after_delete>
        <disk_profile id="c69220b2-0ef2-4ae4-8f10-89b642a7e3e5"/>
        <quota id="5467fe9e-163b-4dce-9c04-329aa3ee0c41">
            <data_center id="0023a401-1695-4c42-aa61-2f7108c0ccb8"/>
        </quota>
        <storage_domains>
            <storage_domain id="9db95765-0fb7-485e-91f2-381354a66d13"/>
        </storage_domains>
    </disk>
</disks>
Comment 4 Sandro Bonazzola 2021-03-18 15:14:22 UTC 
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.
Comment 5 Sandro Bonazzola 2021-03-22 12:55:39 UTC 
This bugzilla is included in oVirt 4.4.5 release, published on March 18th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.