Bug 1927511 (CVE-2020-26299)

Summary: CVE-2020-26299 nodejs-ftp-srv: Path traversal in path.resolve function
Product: [Other] Security Response Reporter: Pedro Sampaio <psampaio>
Component: vulnerabilityAssignee: Red Hat Product Security <security-response-team>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: hvyas
Target Milestone: ---Keywords: Security
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: nodejs-ftp-srv 4.4.0 Doc Type: If docs needed, set a value
Doc Text:
A potential path traversal vulnerability was found in ftp-srv in the 'path.resolve' function. It could occur on a Windows server as it allows the use of backward slash('\') characters as separators in a file path allowing the user to move beyond the root folder defined for that user.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-02-18 11:55:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1927512    

Description Pedro Sampaio 2021-02-10 21:08:06 UTC
ftp-srv is an open-source FTP server designed to be simple yet configurable. In ftp-srv before version 4.4.0 there is a path-traversal vulnerability. Clients of FTP servers utilizing ftp-srv hosted on Windows machines can escape the  FTP user's defined root folder using the expected FTP commands, for example, CWD and UPDR.

When windows separators exist within the path (`\`), `path.resolve` leaves the upper pointers intact and allows the user to move beyond the root folder defined for that user. We did not take that into account when creating the path resolve function.

The issue is patched in version 4.4.0 (commit 457b859450a37cba10ff3c431eb4aa67771122e3).

https://github.com/autovance/ftp-srv/commit/457b859450a37cba10ff3c431eb4aa67771122e3
https://github.com/autovance/ftp-srv/issues/167
https://github.com/autovance/ftp-srv/issues/225
https://github.com/autovance/ftp-srv/pull/224
https://github.com/autovance/ftp-srv/security/advisories/GHSA-pmw4-jgxx-pcq9
https://www.npmjs.com/package/ftp-srv

Comment 1 Hardik Vyas 2021-02-18 11:35:27 UTC
External References:

https://github.com/autovance/ftp-srv/security/advisories/GHSA-pmw4-jgxx-pcq9