Bug 1927938

Summary:	There is an inconsequential (to date) 1 byte buffer overflow in vdo user tools.
Product:	Red Hat Enterprise Linux 8	Reporter:	corwin <corwin>
Component:	vdo	Assignee:	corwin <corwin>
Status:	CLOSED ERRATA	QA Contact:	Filip Suba <fsuba>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	8.1	CC:	awalsh, cwei, emcnabb, fsuba
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	vdo-6.2.5.41-14.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-09 19:28:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description corwin 2021-02-11 21:31:31 UTC

Description of problem:

When setting up for file based access to a VDO's backing device, the file name is copied into a buffer via strcpy(). That buffer is allocated 1 byte too small to contain the terminating \0.

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1. Run any VDO user tool under valgrind.

Actual results:
Valgrind reports: "Invalid write of size 1"

Expected results:
Valgrind does not report any invalid writes.

Additional info:
To date, we have seen no consequences from this issue.

Comment 5 Filip Suba 2021-07-30 09:01:27 UTC

Verified with vdo-6.2.5.41-14.el8.

Comment 8 errata-xmlrpc 2021-11-09 19:28:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (kmod-kvdo bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4359