Bug 1928231

Description of problem:
First of all, in order to reproduce this issue, BZ1926191 needs to be resolved. Otherwise, qos-fip cannot be used with OVN. A hotfix was used to reproduce this bug.

Steps:
1. Create a qos policy with bw limit and/or dscp marking
openstack network qos policy create bw-limiter
openstack network qos rule create --type bandwidth-limit --egress --max-kbps 100 --max-burst-kbits 100 bw-limiter
openstack network qos rule create --type bandwidth-limit --ingress --max-kbps 100 --max-burst-kbits 100 bw-limiter
openstack network qos rule create --type dscp-marking --dscp-mark 26 bw-limiter

2. Assign that qos-policy to an existing FIP (which is attached to a running server)
openstack floating ip set --qos-policy bw-limiter 10.0.0.211

3. Check the qos-policies are NOT applied, which is a bug


Info from the QoS table at NBDB:
[root@controller-2 ~]# ovn-nbctl list QoS  
_uuid               : 647abfc4-49b0-4f2b-ad35-52afd6e4f63c
action              : {}
bandwidth           : {burst=100, rate=100}
direction           : to-lport
external_ids        : {"neutron:fip_id"="158dee8c-fc48-47a0-a29d-48a01710f889"}                                                                                                                                                              
match               : "outport == \"6ab04b5c-ed26-4587-973c-fff2da5c31ab\" && ip4.dst == 10.0.0.211 && is_chassis_resident(\"cr-lrp-6ab04b5c-ed26-4587-973c-fff2da5c31ab\")"                                                                 
priority            : 2002
                                                                                                                                                                                                  
_uuid               : 95883b77-2f04-4019-8d08-85507424f993
action              : {dscp=26}
bandwidth           : {burst=100, rate=100}
direction           : from-lport
external_ids        : {"neutron:fip_id"="158dee8c-fc48-47a0-a29d-48a01710f889"}
match               : "inport == \"6ab04b5c-ed26-4587-973c-fff2da5c31ab\" && ip4.src == 10.0.0.211 && is_chassis_resident(\"cr-lrp-6ab04b5c-ed26-4587-973c-fff2da5c31ab\")"
priority            : 2002


Apparently, the last element of the "match" rule does not match the packets: is_chassis_resident(\"cr-lrp-6ab04b5c-ed26-4587-973c-fff2da5c31ab\")


[root@controller-2 ~]# ovn-sbctl find Port_Binding logical_port="cr-lrp-6ab04b5c-ed26-4587-973c-fff2da5c31ab" | grep "^chassis"
chassis             : 5bead493-9911-4615-94cc-88670f78f1bf       
[root@controller-2 ~]# ovn-sbctl list chassis 5bead493-9911-4615-94cc-88670f78f1bf   | grep hostname
hostname            : controller-0.redhat.local

                                                                                                                                                                             




Version-Release number of selected component (if applicable):
RHOS-16.1-RHEL-8-20210205.n.0

How reproducible:
100%