Bug 1928442

Summary: vim-enhanced is replacing vim-wrappers-8.2.2465-1
Product: [Fedora] Fedora Reporter: Chris Murphy <bugzilla>
Component: vimAssignee: Karsten <karsten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 33CC: gchamoul, karsten, zdohnal
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vim-8.2.2559-1.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-02 15:56:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Chris Murphy 2021-02-14 03:33:42 UTC
Regular updates for F33 (probably F32 as well) are improperly dragging in vim-common and vim-enhanced; on Fedora Workstation and Server.


Installing dependencies:                                                       │
 vim-common                  x86_64   2:8.2.2488-1.fc33        updates   6.7 M │
 vim-enhanced                x86_64   2:8.2.2488-1.fc33        updates   1.8 M │
     replacing  vim-wrappers.noarch 2:8.2.2465-1.fc33                          │
 vim-filesystem              noarch   2:8.2.2488-1.fc33        updates    23 k │
  

I'm not sure why my F33 systems have vim-wrappers, but if I try to remove it first, it wants to remove vim-minimal which is also not correct.

I see the change here but I'm can figure out why this is happening:

https://src.fedoraproject.org/rpms/vim/c/6b04c32679d61d0930ef6a01b294071679e1462b?branch=f33

Comment 1 Chris Murphy 2021-02-14 05:51:03 UTC
Following clean install of F32/F33 (both in VM) and updating, no vim-wrappers. vim-minimal is all that's present. And yet I've got in-use systems, two F33 Workstations and one F33 Server, all have vim-wrappers; and today want to bring in vim-common and vim-enhanced when replacing vim-wrappers. Mystified.

Comment 2 Chris Murphy 2021-02-14 19:28:23 UTC
Workaround:

dnf remove vim-wrappers
## this will remove vim-minimal too
dnf install vim-minimal

Now vim-common and vim-enhanced won't be brought in on updates.

Comment 3 Zdenek Dohnal 2021-02-15 08:58:04 UTC
Hi Chris,

thank you for reporting the issue!

vim-wrappers was a requirement for both vim-minimal and vim-enhanced, so I thought 'Obsoletes:' and 'Conflicts' should do the trick, but I'm able to get the behavior you described too.

'Obsoletes:' is used because of original 'vim-wrappers' doesn't exist anymore[1], and 'Conflicts:' is used because 'vim-wrappers' files are now split between 'vim-minimal' and 'vim-enhanced' (there is a bug where only '<' is used right now, but it doesn't influence the result how I found out after testing it manually).

I'll look into what can be done about it...

[1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages
[2] https://docs.fedoraproject.org/en-US/packaging-guidelines/Conflicts/

Comment 4 Zdenek Dohnal 2021-02-15 15:03:14 UTC
Aha, ok, it looks we need a '-compat' package to solve this[1], I'll check if it helps.



[1] https://fedoraproject.org/wiki/Upgrade_paths_%E2%80%94_renaming_or_splitting_packages

Comment 5 Zdenek Dohnal 2021-03-01 11:05:19 UTC
I talked about the issue with other package maintainers and I'm going to implement the following idea:

'Obsoletes: vim-wrappers < 2:8.2488-2' will be removed from vim-enhanced - this will prevent bringing vim-enhanced in if only vim-minimal was installed in version which brought vim-wrappers (2:8.2.2465-1). 

But, if only vim-enhanced was installed as 2:8.2.2465-1, it will bring vim-minimal. IMO the users which already have vim-enhanced installed don't care too much about amount of installed packages and they can always remove vim-minimal later. And to stress it out - this bug happens only if the specific vim version - 2:8.2.2465-1 - was installed.

Comment 6 Fedora Update System 2021-03-01 12:02:34 UTC
FEDORA-2021-a8e05d3d56 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-a8e05d3d56

Comment 7 Fedora Update System 2021-03-01 12:19:37 UTC
FEDORA-2021-df0674d6cb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-df0674d6cb

Comment 8 Fedora Update System 2021-03-01 17:45:54 UTC
FEDORA-2021-df0674d6cb has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-df0674d6cb`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-df0674d6cb

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2021-03-02 04:31:40 UTC
FEDORA-2021-a8e05d3d56 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-a8e05d3d56`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-a8e05d3d56

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-03-02 15:56:18 UTC
FEDORA-2021-df0674d6cb has been pushed to the Fedora 33 stable repository.
If problem still persists, please make note of it in this bug report.