Bug 1928479

Summary:	Change the display message while re-importing the roles in Satellite, after doing some modification in roles.
Product:	Red Hat Satellite	Reporter:	Gourav Padholia <gpadholi>
Component:	Ansible - Configuration Management	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	Danny Synk <dsynk>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.8.0	CC:	ehelms, oezr
Target Milestone:	6.10.0	Keywords:	EasyFix, Triaged, UserExperience
Target Release:	Unused
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-16 14:10:07 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Gourav Padholia 2021-02-14 11:39:45 UTC

Description of problem:
Modification in the ansible roles is not reflecting on the Satellite web UI while re-importing the roles on Satellite web UI. 

Version-Release number of selected component (if applicable):
Satellite 6.8
ansible 2.7.5

How reproducible:
100 %

Steps to Reproduce:
1. Create or install the ansible roles on the Satellite server and import the roles from Satellite web UI.
2. Modify the roles, i.e. add a task or change the vars/main.yml file. 
3. Import the roles again in the Satellite web UI showing "No changes in roles detected on satellite.example.com". 
4. While running the roles on the clients, showing the changes. 

Actual results:
Import the roles again in the Satellite web UI showing "No changes in roles detected on satellite.example.com".

Expected results:
It should display the modification as the task or variable has been changes in the roles. 

Additional info:
Changes are applied in the roles and it is visible while running the roles but importing the roles showing "No changes in roles detected on satellite.example.com".

Comment 1 Ondřej Ezr 2021-02-14 13:06:52 UTC

Hi, this is not a bug. The import only imports list of the roles, so changing it's content doesn't change anything from Satellite perspective.

The tasks changes will not be detected in the future, so for that we could only reword the message to something more clear like: "No roles were added or removed on the proxy".

The variables are imported separately to satellite, so that may be confusing for users. Changes to variables are shown while importing variables.
This will be changed as part of https://bugzilla.redhat.com/show_bug.cgi?id=1744931 where we will change to import roles and variables together. This is expected to get into 6.10.

Comment 7 Ondřej Ezr 2021-02-16 00:36:22 UTC

Created redmine issue https://projects.theforeman.org/issues/31879 from this bug

Comment 11 Danny Synk 2021-06-21 17:43:03 UTC

Steps to test:

1. On Satellite 6.10, snap 5, log in to the webUI as the admin user.
2. Navigate to Configure > Roles.
3. Click the "Import from satellite.example.com" button.
4. Select all available roles.
5. Click the "Submit" button.
6. Click the "Import from satellite.example.com" button again.

Expected Results:

A notification displays the message "No added or removed roles nor variables detected on satellite.example.com."

Actual Results:

A notification displays the message "No added or removed roles nor variables detected on satellite.example.com."

Conversely, running the same steps on Satellite 6.9 or early shows the message "No changes in roles detected on dhcp-3-106.vms.sat.rdu2.redhat.com."

Verified on Satellite 6.10, snap 5 (tfm-rubygem-foreman_ansible-6.3.0-1.el7sat.noarch).

Comment 14 errata-xmlrpc 2021-11-16 14:10:07 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.10 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4702