Bug 192876
| Summary: | Review Request: V2Strip ID3v2(Mp3 Files) tags remover | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andrea Veri <bluekuja> |
| Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hugo |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-12-22 05:01:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Andrea Veri
2006-05-23 19:05:33 UTC
Review for this package: BLOCKERS: - Package in non-standard group (Applications/Shell), see: http://fedoraproject.org/wiki/RPMGroups - The application don't need the 'openssl-devel' BuildRequires. (Why?) - You must include the COPYING file in %doc's %files. It contains the license of the application (GPL). - ChangeLog should be in %doc too. SHOULD: - When creating a new specfile, the recommended way is to create using the following command: fedora-newrpmspec <package-name> - (Really minor) The arrangement in the specfile could be better. Spacing and these things. The 'fedora-newrpmspec' helps on this. You can look at other specs too. Just to get the specfile more organized and pretty :-) - (Really minor) Description is ok. Consider putting "v2strip is a ..." before the description field. Example: "v2strip is a little utility that removes ID3v2..." OKS: - Source package matches the package from upstream - Builds and works fine - Package name ok Fixed error in comment #1 SPEC: http://www.netservers.org/packages/rpm/v2strip.spec SRPMS: http://www.netservers.org/packages/rpm/v2strip-0.2.10-2.src.rpm BLOCKERS: * Package in non-standard group (Applications/Shells), see: http://fedoraproject.org/wiki/RPMGroups MINOR: * You can drop the NEWS from the docs, since it appears to have the same information as the Changelog file. * Shouldn't refer to the package name in Summary. A better one might be 'ID3v2 tag remover'. Fixed problems in comment #3 SPEC: http://www.netservers.org/packages/rpm/v2strip.spec SRPMS: http://www.netservers.org/packages/rpm/v2strip-0.2.10-2.src.rpm Good: - rpmlint checks return nothing! :) - package meets naming guidelines - package meets packaging guidelines - license (GPL) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file Short, sweet, simple. APPROVED. Andrea if this is built, you need to close this bug. Refer to http://fedoraproject.org/wiki/Extras/NewPackageProcess - step 14. This has been approved for more than 3 months. If it doesn't show movement soon, I'm going to rescind my approval and close this bug. Approval rescinded. Bug closed WONTFIX. |