Bug 1929314

Summary:	ovn-kubernetes endpoint slice controller doesn't run on CI jobs
Product:	OpenShift Container Platform	Reporter:	Antonio Ojea <aojeagar>
Component:	Networking	Assignee:	Antonio Ojea <aojeagar>
Networking sub component:	ovn-kubernetes	QA Contact:	Ross Brattain <rbrattai>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	low	CC:	dcbw, trozet, zzhao
Version:	4.7	Keywords:	Reopened
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: The library used to detect the Kubernetes version in OVN doesn't parse minors versions that are not only numbers, i.e v1.21.0-alpha.1, that are typically all the clusters that run in the CI. Consequence: The new OVN controller for dual-stack doesn't work if the kubernetes version has letters on the minor version Fix: Don´t rely on the kubernetes version to run the OVN controller for dual-stack. Result: The OVN controller for dual-stack will work for any cluster with dual-stack enable	Story Points:	---
Clone Of:
Clones:	1932268 (view as bug list)		Environment:
Last Closed:	2021-07-27 22:44:46 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1932268

Description Antonio Ojea 2021-02-16 16:35:17 UTC

The ovn-kubernetes endpoint slice controller requires the following in order to run:
1. The kubernetes cluster has enabled endpoint slices
2. The OVN configuration has enabled dual-stack
3. The kubernetes version has the new dual-stack API, that means it is > 1.20

The detection of the kubernetes version fails in the CI, because the library doesn't parse minors versions that are not only numbers, i.e v1.21.0-alpha.1, that are typically all the clusters that run in the CI.

We really don't need the 3rd requirement, because the controller can work without dual-stack, so we can go with 1 and 2 for 4.7 and remove the 3rd requirement directly.

For 4.8 the goal is to enable the new endpointslice controller by default.

Comment 1 Antonio Ojea 2021-02-16 16:39:08 UTC

Fix https://github.com/ovn-org/ovn-kubernetes/pull/2049/

Comment 3 Antonio Ojea 2021-02-24 12:12:12 UTC

This bug was fixed as part of the recent rebase from upstream

https://github.com/openshift/ovn-kubernetes/commit/cdabdc3244de873beaac168b7f613f445bdda380

Comment 5 zhaozhanqi 2021-03-30 09:01:09 UTC

@aojeagar Hi, could you help show the CI job with the endpoint slice controller for ovn-kubernetes for verifying this bug? thanks.

Comment 6 Ross Brattain 2021-03-31 13:08:40 UTC

Verified "Starting OVN Service Controller: Using Endpoint Slices" present in CI log files.

	// We use a level triggered controller to handle services if the cluster
	// has endpoint slices enabled.
	if util.UseEndpointSlices(oc.client) {
		klog.Infof("Starting OVN Service Controller: Using Endpoint Slices")


https://prow.ci.openshift.org/view/gs/origin-ci-test/logs/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-ovn-dualstack/1377074392177053696

virthost-ostest-test-metalkube-org-5000-localimages-local-release-image-sha256-f041c0db3b115bf248da6a0782410317e80dadbd96692012dc984dac4aa059e8/namespaces/openshift-ovn-kubernetes/pods/ovnkube-master-mqc52/ovnkube-master/ovnkube-master/logs/previous.log
264:2021-03-31T02:25:04.294503531Z I0331 02:25:04.294494       1 ovn.go:312] Starting OVN Service Controller: Using Endpoint Slices

virthost-ostest-test-metalkube-org-5000-localimages-local-release-image-sha256-f041c0db3b115bf248da6a0782410317e80dadbd96692012dc984dac4aa059e8/namespaces/openshift-ovn-kubernetes/pods/ovnkube-master-jwntj/ovnkube-master/ovnkube-master/logs/previous.log
889:2021-03-31T02:32:34.791490944Z I0331 02:32:34.791479       1 ovn.go:312] Starting OVN Service Controller: Using Endpoint Slices

virthost-ostest-test-metalkube-org-5000-localimages-local-release-image-sha256-f041c0db3b115bf248da6a0782410317e80dadbd96692012dc984dac4aa059e8/namespaces/openshift-ovn-kubernetes/pods/ovnkube-master-jwntj/ovnkube-master/ovnkube-master/logs/current.log
973:2021-03-31T02:40:17.127074364Z I0331 02:40:17.127054       1 ovn.go:312] Starting OVN Service Controller: Using Endpoint Slices

Comment 10 errata-xmlrpc 2021-07-27 22:44:46 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438