Bug 1929799

Summary: Provide information about why an unavailable hook phase is not displayed in the Phase list on the Add Hook screen
Product: Migration Toolkit for Containers Reporter: Erik Nelson <ernelson>
Component: UIAssignee: Ian <ibolton>
Status: CLOSED ERRATA QA Contact: Xin jiang <xjiang>
Severity: low Docs Contact: Avital Pinnick <apinnick>
Priority: medium    
Version: 1.4.0CC: ernelson, rjohnson, sregidor
Target Milestone: ---   
Target Release: 1.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-28 04:08:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Erik Nelson 2021-02-17 16:45:44 UTC
Description of problem:
When a plan already has a hook defined for a particular phase, we filter it from the available options in the dropdown. This leads to confusion because it's not clear to users why a phase is missing.

I'd propose we *keep* the phases in the dropdown, but disable them for selection, and provide a warning tooltip that explains why those are greyed out.

Version-Release number of selected component (if applicable):
1.4.0

How reproducible:
Every time

Steps to Reproduce:
1. Add a hook to PostRestore on a plan
2. Edit the plan and try to add another one on PostRestore, it should not appear in the dropdown list.

Comment 4 Sergio 2021-06-30 10:11:35 UTC
Verified using MTC 1.5.0
  openshift-migration-rhel7-operator@sha256:00e77706ca22bcb557d13c16822180fc877e6ea1639a72fda8eb9f5488b039a2
    - name: MIG_CONTROLLER_REPO
      value: openshift-migration-controller-rhel8@sha256
    - name: MIG_CONTROLLER_TAG
      value: 7f657df15e9514df4ef42da3431f558a19b8d3233a2ef1222cd8e27793c93816
    - name: MIG_UI_REPO
      value: openshift-migration-ui-rhel8@sha256
    - name: MIG_UI_TAG
      value: bda1959e1f44170905499b304ce28f9f95ee1841b0dc29f9a9e2790d0dd0bd71

Now when a hook has been already for a phase, when we add new hooks we see this phase greyed out and cannot be selected. When we hover over the disabled phases we can see this message: "This phase cannot be selected because a hook already exists for this phase"


Moved to VERIFIED

Comment 10 errata-xmlrpc 2021-07-28 04:08:00 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Migration Toolkit for Containers (MTC) image release advisory 1.5.0), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2021:2929