Bug 1929958

Summary:	Review Request: jni-inchi - International Chemical Identifiers for Java
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	Package Review	Assignee:	Zbigniew Jędrzejewski-Szmek <zbyszek>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	dan.cermak, package-review, zbyszek
Target Milestone:	---	Flags:	zbyszek: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	jni-inchi-0.8-1.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-02-23 02:03:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry James 2021-02-18 03:16:11 UTC

Spec URL: https://jjames.fedorapeople.org/jni-inchi/jni-inchi.spec
SRPM URL: https://jjames.fedorapeople.org/jni-inchi/jni-inchi-0.8-1.fc35.src.rpm
Fedora Account System Username: jjames
Description: JNI-InChI enables Java software to generate IUPAC's International Chemical Identifiers (InChIs) by making Java Native Interface (JNI) calls to the InChI C library developed by IUPAC.  All of the features from the InChI libarary are supported:

- Standard and Non-Standard InChI generation from structures with 3D, 2D, or no coordinates
- Structure generation (without coordinates) from InChI
- InChIKey generation
- Check InChI / InChIKey
- InChI-to-InChI conversion
- AuxInfo to InChI input
- Access to the full range of options supported by InChI
- Full support for InChI's handling of stereochemistry

JNI-InChI is a library intended for use by developers of other projects.  It does not enable users to generate InChIs from molecule file formats such as .mol, .cml, .mol2, or SMILES strings.  If you want to do any of these, you should take a look at the Chemistry Development Kit (CDK) or JUMBO, both of which include InChI generation powered by JNI-InChI.  If, however, you are a software developer and you want want to generate the InChI for a molecule that you already hold in memory, JNI-InChI is what you need.

Comment 1 Dan Čermák 2021-02-18 19:13:43 UTC

The package fails to build in Rawhide for me:

JniInchiWrapper.c:25:10: fatal error: ichisize.h: No such file or directory
   25 | #include <ichisize.h>
      |          ^~~~~~~~~~~~
compilation terminated.

Comment 2 Jerry James 2021-02-18 21:23:43 UTC

Yes, it needs the latest build of the inchi package, inchi-1.0.5-12.fc35.  I had hoped that would have reached most mirrors by the time I sent the review swap email, but apparently my hope was in vain.  It is available from koji:

https://koji.fedoraproject.org/koji/buildinfo?buildID=1711565

Hopefully it will be on the mirrors before too much longer.

Comment 3 Jerry James 2021-02-20 17:08:25 UTC

Due to inchi-1.0.6 landing in Rawhide, I have updated this package with a slightly modified inchi patch.  The URLs are the same.

Comment 4 Zbigniew Jędrzejewski-Szmek 2021-02-20 19:53:02 UTC

rpmlint:
jni-inchi.x86_64: W: spelling-error %description -l en_US libarary -> library, literary
jni-inchi.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/jni-inchi/README

jni-inchi: /usr/lib64/jni-inchi/libjniinchi-1.03_1.so
This looks OK. The shared object is in a private directory.

+ package name is OK
+ license is acceptable for Fedora (LGPLv3+)
+ license is specified correctly (http://jni-inchi.sourceforge.net/license.html)
+ builds and installs OK
+ fedora-review and rpmlint find no issues (except the spelling stuff above)
+ the .jar file and .so seem to be in the right directories
+ P/R/BR look OK

Package is APPROVED.

Comment 5 Jerry James 2021-02-21 02:31:04 UTC

Thank you for the review!

(In reply to Zbigniew Jędrzejewski-Szmek from comment #4)
> rpmlint:
> jni-inchi.x86_64: W: spelling-error %description -l en_US libarary ->
> library, literary
> jni-inchi.x86_64: W: wrong-file-end-of-line-encoding
> /usr/share/doc/jni-inchi/README

I will fix both of these prior to importing.  Thanks for catching them.

Comment 6 Mohan Boddu 2021-02-22 22:59:46 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/jni-inchi

Comment 7 Jerry James 2021-02-23 02:03:29 UTC

Built for F34 and Rawhide.