Bug 1930096
| Summary: | Unexpected shifting elfdepargs --filter-private | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Honggang LI <honli> |
| Component: | rpm-mpi-hooks | Assignee: | Sandro Mani <manisandro> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | infiniband-qe, linville, manisandro, rdma-dev-team, wasphin |
| Target Milestone: | --- | Keywords: | Triaged |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | rpm-mpi-hooks-7-1.fc33 rpm-mpi-hooks-8-1.fc32 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1924665 | Environment: | |
| Last Closed: | 2021-02-26 23:54:43 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1924665 | ||
| Bug Blocks: | |||
|
Description
Honggang LI
2021-02-18 11:07:14 UTC
It seems this simple patch fixes the issue.
rpm-mpi-hooks (rawhide *)]$ git diff
diff --git a/mpi.attr b/mpi.attr
index 03ea6af..22aea42 100644
--- a/mpi.attr
+++ b/mpi.attr
@@ -1,5 +1,5 @@
-%__mpi_provides %{_rpmconfigdir}/mpi.prov %{?__filter_GLIBC_PRIVATE:--filter-private}
-%__mpi_requires %{_rpmconfigdir}/mpi.req %{?__filter_GLIBC_PRIVATE:--filter-private}
+%__mpi_provides %{_rpmconfigdir}/mpi.prov --provides %{?__filter_GLIBC_PRIVATE:--filter-private}
+%__mpi_requires %{_rpmconfigdir}/mpi.req --requires %{?__filter_GLIBC_PRIVATE:--filter-private}
%__mpi_path ^%{_prefix}/lib(64)?/.*$
%__mpi_magic ^(setuid )?(setgid )?(sticky )?ELF (32|64)-bit.*$
%__mpi_flags exeonly,magic_and_path
--provides and --requires are already passed to /usr/lib/rpm/elfdeps inside mpi.req resp. mpi.prov, this would result in it getting passed twice? (In reply to Sandro Mani from comment #2) > --provides and --requires are already passed to /usr/lib/rpm/elfdeps inside > mpi.req resp. mpi.prov, this would result in it getting passed twice? No, as the first parameter(--provides/--requires) has already been shifted in mpi.prov/mpi.req. $ cat -n /usr/lib/rpm/mpi.prov ...... 30 # Remaining arguments are passed to elfdeps 31 shift 32 elfdepsargs="$@" ...... (In reply to Honggang LI from comment #1) > It seems this simple patch fixes the issue. > > rpm-mpi-hooks (rawhide *)]$ git diff > diff --git a/mpi.attr b/mpi.attr > index 03ea6af..22aea42 100644 > --- a/mpi.attr > +++ b/mpi.attr > @@ -1,5 +1,5 @@ > -%__mpi_provides %{_rpmconfigdir}/mpi.prov > %{?__filter_GLIBC_PRIVATE:--filter-private} > -%__mpi_requires %{_rpmconfigdir}/mpi.req > %{?__filter_GLIBC_PRIVATE:--filter-private} > +%__mpi_provides %{_rpmconfigdir}/mpi.prov --provides > %{?__filter_GLIBC_PRIVATE:--filter-private} > +%__mpi_requires %{_rpmconfigdir}/mpi.req --requires > %{?__filter_GLIBC_PRIVATE:--filter-private} > %__mpi_path ^%{_prefix}/lib(64)?/.*$ > %__mpi_magic ^(setuid )?(setgid )?(sticky )?ELF (32|64)-bit.*$ > %__mpi_flags exeonly,magic_and_path Why not just remove the ``shift`` in mpi.prov and mpi.req? And I'm not sure whether this works for /usr/lib/rpm/fileattrs/mpilibsymlink.attr? $ rpm -ql rpm-mpi-hooks-5-4.el8.noarch /usr/lib/rpm/fileattrs/mpi.attr /usr/lib/rpm/fileattrs/mpilibsymlink.attr /usr/lib/rpm/mpi.prov /usr/lib/rpm/mpi.req /usr/share/licenses/rpm-mpi-hooks /usr/share/licenses/rpm-mpi-hooks/LICENSE $ cat -n /usr/lib/rpm/fileattrs/mpilibsymlink.attr 1 # Make libfoo.so symlinks require the soname-provide of the target library 2 %__mpilibsymlink_requires %{_rpmconfigdir}/mpi.prov %{buildroot} --soname-only 3 %__mpilibsymlink_magic ^symbolic link to .*lib.*\.so\..*$ 4 %__mpilibsymlink_path ^%{_prefix}/lib(64)?/.*\.so$ 5 %__mpilibsymlink_flags magic_and_path 6 %__libsymlink_exclude_path ^%{_prefix}/lib(64)?/.*$ I see now - the shift is a left-over oversight from before [1], I'll just drop it. [1] https://src.fedoraproject.org/rpms/rpm-mpi-hooks/c/a9457917b1a04ba4b68678676689194fa907abd9?branch=rawhide FEDORA-2021-d823321a2d has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d823321a2d FEDORA-2021-4e977a8858 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4e977a8858 Confirmed the patch works for me. thanks FEDORA-2021-d823321a2d has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-d823321a2d` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d823321a2d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-4e977a8858 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-4e977a8858` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4e977a8858 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-4e977a8858 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-8f5d163f67 has been pushed to the Fedora 32 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-8f5d163f67` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8f5d163f67 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-8f5d163f67 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. |