Bug 1930240

Summary: Generated clouds.yaml incomplete when provisioning network is disabled
Product: OpenShift Container Platform Reporter: Steven Hardy <shardy>
Component: InstallerAssignee: Caleb Boylan <cboylan>
Installer sub component: OpenShift on Bare Metal IPI QA Contact: Raviv Bar-Tal <rbartal>
Status: CLOSED ERRATA Docs Contact:
Severity: low    
Priority: low CC: cboylan, rbartal
Version: 4.8Keywords: Triaged
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Cause: No dedicated provisioning network Consequence: IP is missing from clouds.yaml Fix: use APIVIP to populate clouds.yaml Result: clouds.yaml has the correct IP when there is no dedicated provisioning network
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 22:45:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Steven Hardy 2021-02-18 14:58:36 UTC
Platform:

baremetal IPI

When deploying with the provisioning network disabled, the generated bootstrap VM clouds.yaml (which is used only for debugging AFAIK) is incomplete, e.g:

$ ssh core.111.54 sudo cat /opt/metal3/auth/clouds.yaml
clouds:
  metal3-bootstrap:
    auth_type: http_basic
    username: bootstrap-user
    password: thepassword
    baremetal_endpoint_override: http://:6385/v1
    baremetal_introspection_endpoint_override: http://:5050/v1

In the case where there is no provisioning network, there is no dedicated provisioning IP, which is expected in the templating here:

https://github.com/openshift/installer/blob/master/data/data/bootstrap/baremetal/files/opt/metal3/auth/clouds.yaml.template#L6..L7

Instead I think we need to populate the IP at runtime, e.g somewhere in:

https://github.com/openshift/installer/blob/master/data/data/bootstrap/baremetal/files/usr/local/bin/startironic.sh.template

This could potentially just sed a placeholder in the templated file after discovering the active IP for PROVISIONING_NIC

How to reproduce:

In a dev-scripts environment, deploy with these in your config_$USER.sh
export PROVISIONING_NETWORK_PROFILE=Disabled
export OPENSHIFT_INSTALL_PRESERVE_BOOTSTRAP=y

Alternatively any deployment where provisioningNetwork: "Disabled" is configured in the install-config should show the same behavior

Comment 4 errata-xmlrpc 2021-07-27 22:45:22 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438