Bug 1930302

Summary: glibc: provide IPPROTO_MPTCP definition
Product: Red Hat Enterprise Linux 8 Reporter: Paolo Abeni <pabeni>
Component: glibcAssignee: Carlos O'Donell <codonell>
Status: CLOSED ERRATA QA Contact: Sergey Kolosov <skolosov>
Severity: unspecified Docs Contact: Eva-Lotte Gebhardt <egebhard>
Priority: unspecified    
Version: 8.4CC: ashankar, codonell, dj, fweimer, mnewsome, pfrankli, sipoyare
Target Milestone: rcKeywords: FutureFeature, Patch, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glibc-2.28-154.el8 Doc Type: Bug Fix
Doc Text:
.`Glibc` now includes definitions for `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP` Previously, the `Glibc` system library headers (`/usr/include/netinet/in.h`) did not include definitions of `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP`. As a consequence, applications needing these definitions failed to compile. With this update, the system library headers now include the new network constant definitions for `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP` resulting in correctly compiling applications.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 19:28:09 UTC Type: Enhancement
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Paolo Abeni 2021-02-18 16:40:04 UTC
This is a request for backporting upstream commit:

commit f9ac84f92f151e07586c55e14ed628d493a5929d
Author: Joseph Myers <joseph>
Date:   Fri Apr 3 18:08:28 2020 +0000

    Add IPPROTO_ETHERNET and IPPROTO_MPTCP from Linux 5.6 to netinet/in.h.

so that user space application willing to migrate to MPTCP could do that more easily.

Comment 4 Sergey Kolosov 2021-04-12 09:56:34 UTC
No regressions have been found.

Comment 5 Eva-Lotte Gebhardt 2021-06-14 10:19:18 UTC
Hi Carlos,

this is my first draft for this bugfix RN. It would be great if you could provide some feedback on the correctness of the information!
Thank you very much!


.`Glibc` system library headers now include definitions for `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP`

Previously, the system library headers (/usr/include/netinet/in.h) did not include definitions of `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP`. As a consequence, applications needing these definitions failed to compile. With this update, the system library headers now include the new network constant definitions for `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP` resulting in correctly compiling applications.

Comment 6 Carlos O'Donell 2021-06-14 12:20:49 UTC
(In reply to Eva-Lotte Gebhardt from comment #5)
> Hi Carlos,
> 
> this is my first draft for this bugfix RN. It would be great if you could
> provide some feedback on the correctness of the information!
> Thank you very much!
> 
> 
> .`Glibc` system library headers now include definitions for
> `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP`
> 
> Previously, the system library headers (/usr/include/netinet/in.h) did not
> include definitions of `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and
> `INADDR_ALLSNOOPERS_GROUP`. As a consequence, applications needing these
> definitions failed to compile. With this update, the system library headers
> now include the new network constant definitions for `IPPROTO_ETHERNET`,
> `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP` resulting in correctly
> compiling applications.

I would remove this:
"resulting in correctly compiling applications"

It is sufficient to say the constant are now defined. If you want to go
further I would add:
"Applications using these constants can now be compiled."

Comment 7 Eva-Lotte Gebhardt 2021-06-14 12:25:08 UTC
Thank you very much, Carlos!

The updated draft now looks like this:

.`Glibc` system library headers now include definitions for `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP`

Previously, the system library headers (/usr/include/netinet/in.h) did not include definitions of `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP`. As a consequence, applications needing these definitions failed to compile. With this update, the system library headers now include the new network constant definitions for `IPPROTO_ETHERNET`, `IPPROTO_MPTCP`, and `INADDR_ALLSNOOPERS_GROUP`. Applications using these constants can now be compiled.

Comment 9 errata-xmlrpc 2021-11-09 19:28:09 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: glibc security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4358