Bug 1931696
| Summary: | Review Request: trelby - The free, multiplatform, feature-rich screenwriting program | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
| Component: | Package Review | Assignee: | Gabriel Gaspar Becker <ggasparb> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | jskarvad, package-review |
| Target Milestone: | --- | Flags: | jskarvad:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-03-12 20:30:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gwyn Ciesla
2021-02-22 23:59:26 UTC
SRPM: https://fedorapeople.org/~limb/review/trelby/trelby-2.4.1-1.fc33.src.rpm SPEC: https://fedorapeople.org/~limb/review/trelby/trelby.spec Review: F35 (rawhide) Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=63067743 Requests: 1) trelby.spec:37: Do not use hardcoded prefix. Use %{_prefix} instead Notes: 1) Spellcheck fails on the "multiplatform" word from the description, but it should be fine to leave it like this. Rpmlint ------- Checking: trelby-2.4.1-1.fc35.noarch.rpm trelby-2.4.1-1.fc35.src.rpm trelby.noarch: W: spelling-error Summary(en_US) multiplatform -> multiform, formulation, formulator trelby.src: W: spelling-error Summary(en_US) multiplatform -> multiform, formulation, formulator 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- trelby.noarch: W: spelling-error Summary(en_US) multiplatform -> multiform, formulation, formulator 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Source checksums ---------------- https://github.com/limburgher/trelby/archive/2.4.1/trelby-2.4.1.tar.gz : CHECKSUM(SHA256) this package : d727b0e14fdef5c26b166257cd8b9bd8444751b910f797fa92d83c44799ae6cf CHECKSUM(SHA256) upstream package : d727b0e14fdef5c26b166257cd8b9bd8444751b910f797fa92d83c44799ae6cf Requires -------- trelby (rpmlib, GLIBC filtered): /usr/bin/python3 hicolor-icon-theme python(abi) python3-lxml python3-wxpython4 Provides -------- trelby: application() application(trelby.desktop) trelby Updated, thank you! SRPM: https://fedorapeople.org/~limb/review/trelby/trelby-2.4.1-2.fc33.src.rpm SPEC: https://fedorapeople.org/~limb/review/trelby/trelby.spec I can see three problems: - it installs desktop file, it should be validated by desktop-file-validate - python3-mock is deprecated, unittest.mock from the standard library should be used instead. New packages shouldn't depend on deprecated functionality - it seems it contains icons based on the Faenza icon set which is IMHO GPLv3+ Good catches. I've fixed the license tag and the desktop file validation, and moved to unittest.mock. SRPM: https://fedorapeople.org/~limb/review/trelby/trelby-2.4.2-1.fc33.src.rpm SPEC: https://fedorapeople.org/~limb/review/trelby/trelby.spec Gwyn, thank you for addressing the requests. It looks good now. F35 (rawhide) scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=63125941 Setting fedora-review+ as a proxy. "The Bugzilla bug's review is approved by a user that is not a packager" Once that's sorted out, Gabriel can set the flag. Thanks all! (In reply to Gwyn Ciesla from comment #8) > "The Bugzilla bug's review is approved by a user that is not a packager" > > Once that's sorted out, Gabriel can set the flag. > > Thanks all! The + flag was set by me, all checked by me, I am packager and sponsor of Gabriel. Right, but the tooling needs the + flag and the person the BZ is assigned to to match. p, I'll assign it to you, run the repo request, and assign back to Gabriel. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/trelby Ah sorry, this is new for me, sorry for inconvenience. No worries. :) FEDORA-2021-d327387713 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-d327387713 FEDORA-2021-6af36057a8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-6af36057a8 FEDORA-2021-d327387713 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-d327387713 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-d327387713 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-6af36057a8 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-6af36057a8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-6af36057a8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2021-6af36057a8 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2021-d327387713 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report. |