Bug 1931996

Summary:	pulp3: Attempting to clone a repo with no metadata gives misleading error message
Product:	Red Hat Satellite	Reporter:	Stephen Wadeley <swadeley>
Component:	Pulp	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED ERRATA	QA Contact:	Stephen Wadeley <swadeley>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	6.9.0	CC:	dalley, ggainey, jsherril, rchan, smallamp, ttereshc
Target Milestone:	6.10.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-11-16 14:10:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Stephen Wadeley 2021-02-23 17:35:49 UTC

Description of problem:

On a system migrated to Pulp3:

Configuring a repo with this URL: https://stephenw.fedorapeople.org/fakerepos/update-errata/
which has no metadata, and attempting to clone, gives misleading error message:

"A no valid remote URL was provided."  

Firstly, (poor English, please change to: No valid remote URL provided

but, checking on Pulp2 system I see it fails to with: RPM1004: Error retrieving metadata: Not Found 


that is a much better error message in this case.


Version-Release number of selected component (if applicable):
Sat6.9 snap 13 migrated to Pulp3

How reproducible:
not sure

Steps to Reproduce:
1. Configure repo with URL pointing to list of RPMS, no metadata
2. Attempt to sync repo

Actual results:
"A no valid remote URL was provided."  

Expected results:
RPM1004: Error retrieving metadata: Not Found

Comment 2 Justin Sherrill 2021-02-25 15:33:27 UTC

Yep, this is an error message from pulp: https://github.com/pulp/pulp_rpm/blob/7e93612346ec5ad2cee0293de026bfb236c03bb4/pulp_rpm/app/tasks/synchronizing.py#L221

moving to pulp

Comment 3 Daniel Alley 2021-04-13 19:51:24 UTC

This is fixed in 3.10 https://github.com/pulp/pulp_rpm/commit/c7753780282d97d9dfa5180a741549d9c448a81f#diff-fb406f31027edc1c5b65abe7635bbd2830a7cc05c24a487344d7649017d14628L221

Comment 4 Tanya Tereshchenko 2021-04-20 11:28:46 UTC

Hi Stephen,

The English part is fixed in pulp_rpm 3.10 as Daniel mentioned.

In my opinion, the new message is potentially more clear for the end user.
As a user, what should I do if Pulp says "Error retrieving metadata: Not Found"?
When I get "No valid remote URL was provided", I understand that I need to check a remote which I, as a user, provided myself.
Would you agree?

I also understand that Satellite terminology do not use `remotes` while for the upstream Pulp it's a resource any user is very aware of and familiar with.
Not sure what we can do here.

Let me know if you still have concerns or if it's ok to have it as it is now (see BZ1931996#c3).

Thanks.

Comment 5 Stephen Wadeley 2021-04-20 12:15:17 UTC

Hello Tanya

I get your point, the inability to find metadata could be caused by many things, such as incorrect URL or by the fact its just not there in the repo.

If Pulp3 does not have a system of error codes then I accept the change in comment #3

Thank you

Comment 7 Stephen Wadeley 2021-06-14 06:46:42 UTC

Hello

testing with 6.10.0-4.0

attempt to sync a repo with no manifest

you have to go to the subtask, where you will now see:

An invalid remote URL was provided.

if you click on the Errors tab, you can see:

Katello::Errors::Pulp3Error: An invalid remote URL was provided.

Thank you

Comment 8 pulp-infra@redhat.com 2021-10-12 14:09:47 UTC

The Pulp upstream bug status is at CLOSED - CURRENTRELEASE. Updating the external tracker on this bug.

Comment 9 pulp-infra@redhat.com 2021-10-12 14:09:48 UTC

The Pulp upstream bug priority is at Normal. Updating the external tracker on this bug.

Comment 12 errata-xmlrpc 2021-11-16 14:10:12 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.10 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4702