Bug 1933070
| Summary: | Disable launcher hooks by default | ||
|---|---|---|---|
| Product: | Container Native Virtualization (CNV) | Reporter: | Fabian Deutsch <fdeutsch> |
| Component: | Installation | Assignee: | Simone Tiraboschi <stirabos> |
| Status: | CLOSED ERRATA | QA Contact: | Inbar Rose <irose> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 2.6.0 | CC: | cnv-qe-bugs, ibesso, nunnatsa, stirabos |
| Target Milestone: | --- | Keywords: | EasyFix |
| Target Release: | 2.6.1 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | hco-bundle-registry-container-v2.6.1-67 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-04-07 08:46:03 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Deutsch
2021-02-25 15:50:22 UTC
I'm not sure if this is a kubevirt or hco issue @nunnatsa where is the bug? In regards to the question asked in Comment #1, KubeVirt exposes the "Sidecar" feature gate to enable/disable this feature. However, HCO currently enables these feature gates: DataVolumes,SRIOV,LiveMigration,CPUManager,CPUNodeDiscovery,Sidecar,Snapshot ------- Thus I'm re-assigning this BZ to the Install component. Feel free to move it back to virt if you think this is in error. This is exactly the opposite of: https://bugzilla.redhat.com/1745328 Are we fine with reverting it? I'm not aware for a reason of why it needs to be enabled by default today. IOW: Let's disable it by default (unless we see a reason, then raise it), but have the ability to enable it as needed. I have verified the bug after installing CNV 2.6.1 on a cluster (osbs - registry-proxy.engineering.redhat.com/rh-osbs/iib:62250) and Sidecar is not there: [cnv-qe-jenkins@besso-1933070-zlrc2-executor ~]$ oc get csv -A NAMESPACE NAME DISPLAY VERSION REPLACES PHASE openshift-cnv kubevirt-hyperconverged-operator.v2.6.1 OpenShift Virtualization 2.6.1 kubevirt-hyperconverged-operator.v2.6.0 Succeeded openshift-local-storage local-storage-operator.4.7.0-202103202139.p0 Local Storage 4.7.0-202103202139.p0 Succeeded openshift-operator-lifecycle-manager packageserver Package Server 0.17.0 Succeeded openshift-storage ocs-operator.v4.7.0-336.ci OpenShift Container Storage 4.7.0-336.ci Succeeded [cnv-qe-jenkins@besso-1933070-zlrc2-executor ~]$ oc get configmap -n openshift-cnv kubevirt-config -o json | jq '.data["feature-gates"]' "DataVolumes,SRIOV,LiveMigration,CPUManager,CPUNodeDiscovery,Snapshot" [cnv-qe-jenkins@besso-1933070-zlrc2-executor ~]$ Before marking the bug as verified, I will verify in upgrade from CNV 2.6.0 (production) to 2.6.1 (osbs). Following my previous comment, I verified that the Sidecar does not exist anymore. Moving to VERIFIED. Since this fix is not related to upgrade, the expected results after upgrade needs to be defined and I will add an automation test for that in the future. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (CNV 2.6.1 Images), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:1126 |