Bug 1933173

Summary:	openshift-sdn/sdn DaemonSet should use maxUnavailable: 10%
Product:	OpenShift Container Platform	Reporter:	W. Trevor King <wking>
Component:	Networking	Assignee:	jamo luhrsen <jluhrsen>
Networking sub component:	openshift-sdn	QA Contact:	zhaozhanqi <zzhao>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	high
Priority:	high	CC:	aconstan, smalleni
Version:	4.8
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:
Clones:	1933174 1933179 1933180 1937306 2003800 (view as bug list)		Environment:
Last Closed:	2021-07-27 22:48:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1937306, 2003800

Description W. Trevor King 2021-02-25 20:55:29 UTC

It's currently maxUnavailable: 1, but we want maxUnavailable: 10%, so we scale better on clusters with large node-counts.  Checking a recent 4.8 CI release:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/logs/release-openshift-origin-installer-e2e-gcp-4.8/1364411741282242560/artifacts/e2e-gcp/daemonsets.json | jq -r '.items[] | select(.spec.template.spec.nodeSelector["node-role.kubernetes.io/master"] != "" and .spec.updateStrategy.rollingUpdate.maxUnavailable != "10%") | .metadata.namespace + " " + .metadata.name + " " + (.spec.template.spec.nodeSelector | tostring) + " " + (.spec.updateStrategy | tostring)'
...
openshift-sdn sdn {"kubernetes.io/os":"linux"} {"rollingUpdate":{"maxUnavailable":1},"type":"RollingUpdate"}

Like bug 1933159, but different DaemonSet.

Comment 4 zhaozhanqi 2021-03-09 01:19:59 UTC

Verified this on 4.8.0-0.nightly-2021-03-08-184701

Comment 7 errata-xmlrpc 2021-07-27 22:48:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438

Comment 10 W. Trevor King 2021-09-09 04:57:30 UTC

This is not my component, so it's not my decision about whether or not to backport to 4.7.  Clearing my NEEDINFO.

Comment 11 jamo luhrsen 2021-09-09 17:57:10 UTC

from what I can tell this did not get cherry-picked down to 4.7. I can handle that if it's needed, but I'll wait until it's asked for.