Bug 1933472

Summary:	Review Request: perl-SQL-Abstract-Pg - PostgreSQL features for SQL::Abstract
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-SQL-Abstract-Pg-1.0-1.fc35	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-03-26 08:08:11 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1931111

Description Emmanuel Seyman 2021-02-28 08:02:44 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-SQL-Abstract-Pg/perl-SQL-Abstract-Pg.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-SQL-Abstract-Pg/perl-SQL-Abstract-Pg-1.0-1.fc33.src.rpm
Description:
SQL::Abstract::Pg extends SQL::Abstract with a few PostgreSQL features used
by Mojo::Pg.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2021-03-04 12:16:08 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-SQL-Abstract-Pg-1.0-1.fc35.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(:MODULE_COMPAT_5.32.1)
      1 perl(parent)
      1 perl(SQL::Abstract)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-SQL-Abstract-Pg-1.0-1.fc35.noarch.rpm | sort | uniq -c
      1 perl(SQL::Abstract::Pg) = 1.0
      1 perl-SQL-Abstract-Pg = 1.0-1.fc35
Binary provides are Ok.

$ rpmlint ./perl-SQL-Abstract-Pg*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok


TODO: Please consider to move LICENSE for %doc to %license in %files section

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 2 Emmanuel Seyman 2021-03-04 18:51:41 UTC

(In reply to Jitka Plesnikova from comment #1)
> 
> TODO: Please consider to move LICENSE for %doc to %license in %files section

Not sure how I missed this one. This will be fixed upon import.


> Resolution:
> Approved

Thank you for the review, Jitka.

I've requested the repo:
https://pagure.io/releng/fedora-scm-requests/issue/32539

Comment 3 Tomas Hrcka 2021-03-05 08:48:06 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-SQL-Abstract-Pg