Bug 1933607

Summary:	Prevent reconcile of labels on all monitoring resources deployed by ocs-operator
Product:	[Red Hat Storage] Red Hat OpenShift Container Storage	Reporter:	Ohad <omitrani>
Component:	ocs-operator	Assignee:	umanga <uchapaga>
Status:	CLOSED ERRATA	QA Contact:	Elad <ebenahar>
Severity:	medium	Docs Contact:
Priority:	high
Version:	4.7	CC:	ebenahar, etamir, madam, muagarwa, ocs-bugs, ratamir, sabose, sostapov, uchapaga
Target Milestone:	---	Keywords:	FutureFeature
Target Release:	OCS 4.7.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	4.7.0-283.ci	Doc Type:	Enhancement
Doc Text:		Story Points:	---
Clone Of:
Clones:	1936405 (view as bug list)		Environment:
Last Closed:	2021-05-19 09:20:01 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1936405

Description Ohad 2021-03-01 09:15:02 UTC

Description of problem (please be detailed as possible and provide log
snippests):

The ocs-osd-deployer (the operator that is responsible to deploy OCS in an OpenShit dedicated environment) is deploying a custom monitoring stack (prometous + alertmanager) to comply with the requirements and restrictions enforced by openshift dedicated. 

This new monitoring stack needs to be able to reconcile and act on all the monitoring resources deployed by the OCS product. 

Prometheus discovery method for monitoring resources is based on a label selector. As such ocs-csd-deployer needs the ability to add/remove labels on all monitoring resources deployed by the OCS product. 

Currently, all changes to the labels of monitoring resources deployed by OCS are reverted by the reconcile loop of OCS components. 


Version of all relevant components (if applicable):



Does this issue impact your ability to continue to work with the product
(please explain in detail what is the user impact)?
Does not allow correct deployment on an openshift dedicated environment 


Is there any workaround available to the best of your knowledge?
no


Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?


Can this issue reproducible?


Can this issue reproduce from the UI?


If this is a regression, please provide more details to justify this:


Steps to Reproduce:
1.
2.
3.


Actual results:


Expected results:


Additional info:

Comment 3 umanga 2021-03-01 12:27:47 UTC

Giving devel_ack+ since this is required to enable Managed OCS monitoring.

Fix: https://github.com/openshift/ocs-operator/pull/1099

Comment 4 Sahina Bose 2021-03-01 14:04:20 UTC

Raz, can we have qe_ack?

Comment 5 Elad 2021-03-01 14:21:44 UTC

QA acking based on https://bugzilla.redhat.com/show_bug.cgi?id=1933609#c7

Comment 9 Elad 2021-03-09 11:58:22 UTC

For verification, only regression testing is needed

Comment 12 Elad 2021-03-25 22:58:38 UTC

Moving to VERIFIED based on regression testing using v4.7.0-318.ci

Comment 14 errata-xmlrpc 2021-05-19 09:20:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Red Hat OpenShift Container Storage 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2041