Bug 1933630
Summary: | [Local Volume] Provision disk failed when disk label has unsupported value like ":" | ||||||
---|---|---|---|---|---|---|---|
Product: | OpenShift Container Platform | Reporter: | Wei Duan <wduan> | ||||
Component: | Storage | Assignee: | Rohan CJ <rojoseph> | ||||
Storage sub component: | Local Storage Operator | QA Contact: | Chao Yang <chaoyang> | ||||
Status: | CLOSED ERRATA | Docs Contact: | |||||
Severity: | medium | ||||||
Priority: | unspecified | CC: | aos-bugs, jsafrane | ||||
Version: | 4.7 | ||||||
Target Milestone: | --- | ||||||
Target Release: | 4.8.0 | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: |
Cause:
LSO was attempting to create a PV with invalid label value because the device-id was not a valid label value.
Consequence:
PV creation fails when device-id has unsupported characters like ":"
Fix:
Move device information from labels to annotations.
Result:
PV creation succeeds.
|
Story Points: | --- | ||||
Clone Of: | |||||||
: | 1963899 (view as bug list) | Environment: | |||||
Last Closed: | 2021-07-27 22:48:28 UTC | Type: | Bug | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 1963899 | ||||||
Attachments: |
|
Description
Wei Duan
2021-03-01 10:14:50 UTC
Add the local storage version: oc get csv -A NAMESPACE NAME DISPLAY VERSION REPLACES PHASE openshift-local-storage local-storage-operator.4.7.0-202102110027.p0 Local Storage 4.7.0-202102110027.p0 Succeeded And all the records from /dev/disk/by-id/ sh-4.4# ls -l /dev/disk/by-id/ total 0 lrwxrwxrwx. 1 root root 9 Mar 1 07:01 scsi-1LIO-ORG_disk01:60c21f72-174c-467b-a592-f9cd88ff01b2 -> ../../sdb lrwxrwxrwx. 1 root root 9 Mar 1 07:01 scsi-1LIO-ORG_disk02:c0708dd2-606a-490d-863c-009bff119cfd -> ../../sdd lrwxrwxrwx. 1 root root 9 Mar 1 07:01 scsi-3600140560c21f72174c467ba592f9cd8 -> ../../sdb lrwxrwxrwx. 1 root root 9 Mar 1 07:01 scsi-36001405c0708dd2606a490d863c009bf -> ../../sdd lrwxrwxrwx. 1 root root 9 Mar 1 07:01 scsi-SLIO-ORG_disk01_60c21f72-174c-467b-a592-f9cd88ff01b2 -> ../../sdb lrwxrwxrwx. 1 root root 9 Mar 1 07:01 scsi-SLIO-ORG_disk02_c0708dd2-606a-490d-863c-009bff119cfd -> ../../sdd lrwxrwxrwx. 1 root root 9 Mar 1 07:01 wwn-0x600140560c21f72174c467ba592f9cd8 -> ../../sdb lrwxrwxrwx. 1 root root 9 Mar 1 07:01 wwn-0x6001405c0708dd2606a490d863c009bf -> ../../sdd Created attachment 1760136 [details]
lsv_log
Having /dev/disk/by-id names in PV labels is problematic, as they can have weird characters. We need either escape those (ugly!) or move them to annotations (but then you can't select them using a label selector - do we need this?) To verify, check if PV labels with keys storage.openshift.com/device-name,storage.openshift.com/device-id move to annotations. oc get pv local-pv-8f6c0fad -o json | jq .metadata.annotations { "storage.openshift.com/device-id": "scsi-1LIO-ORG_disk02:0c52d090-31ca-469d-9805-d743d467942d", "storage.openshift.com/device-name": "sdc" } local-storage-operator.4.8.0-202104231341.p0 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:2438 |