Bug 1933768

Summary: cloud-utils-growpart: Wrong parsing of sfdisk output in french locale
Product: Red Hat Enterprise Linux 8 Reporter: Nicolas Chauvet (kwizart) <kwizart>
Component: cloud-utils-growpartAssignee: Eduardo Otubo <eterrell>
Status: CLOSED ERRATA QA Contact: xiachen
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: CentOS StreamCC: bstinson, carl, eterrell, huzhao, jwboyer, ldu, ribarry, xiachen, xiliang, yacao, yuxisun
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cloud-utils-growpart-0.31-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 18:43:52 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nicolas Chauvet (kwizart) 2021-03-01 16:39:06 UTC
Description of problem:
As reported in upstream cloud-utils, if growpart is used when the locale is set, the disk parsing is wrong leading to failure to extend the partition.

Version-Release number of selected component (if applicable):
cloud-utils-growpart-0.31-1

How reproducible:
always

Steps to Reproduce:
1. extend any pre-existing VM local disk.
2. export LANG=fr_FR-utf8 (or in cloud meta-data)
3. run growpart -N /dev/vda 2


Actual results:
./growpart -N /dev/vda 2
./growpart: ligne 322: 22548578304 octets, : erreur de syntaxe : opérateur arithmétique non valable (le symbole erroné est «  octets, »)

(an attempt to divide by a variable containing some text).

Expected results:
CHANGE: partition=2 start=2099200 old: size=39843840 end=41943040 new: size=41940959 end=44040159
# === old sfdisk -d ===
label: dos
label-id: 0x2ea6aa65
device: /dev/vda
unit: sectors

/dev/vda1 : start= 2048, size= 2097152, type=83, bootable
/dev/vda2 : start= 2099200, size= 39843840, type=8e
# === new sfdisk -d ===
label: dos
label-id: 0x2ea6aa65
device: /dev/vda
unit: sectors

/dev/vda1 : start= 2048, size= 2097152, type=83, bootable
/dev/vda2 : start= 2099200, size= 41940959, type=8e

Additional info:

PR for git.centos.org in progress...

Comment 1 Nicolas Chauvet (kwizart) 2021-03-01 17:16:02 UTC
Upstream bug: https://bugs.launchpad.net/cloud-utils/+bug/1860479
Pagure MR for git.centos.org: https://git.centos.org/rpms/cloud-utils-growpart/pull-request/1

Comment 2 xiachen 2021-03-02 10:23:26 UTC
Reproduced the issue with cloud-utils-growpart-0.31-1.el8.noarch on RHEL8.4 in french locale (LANG=fr_FR.UTF-8)
set qa_ack+

According to the code changes https://github.com/canonical/cloud-utils/pull/28, 
I modified the source code of growpart and verified it, result is PASS.
so once the MR is accepted by upstream, we can merge it to downstream.

Comment 3 Nicolas Chauvet (kwizart) 2021-03-19 16:44:21 UTC
(In reply to xiachen from comment #2)
Hello xiachen,


Just a notification that the PR have just been accepted upstream.

Thanks for your work on this issue.
Have a nice day.

Comment 4 xiachen 2021-03-22 13:40:59 UTC
Great! thanks for your notification.
I think, Eduardo will do the backport to downstream according to his plan.


(In reply to Nicolas Chauvet (kwizart) from comment #3)
> (In reply to xiachen from comment #2)
> Hello xiachen,
> 
> 
> Just a notification that the PR have just been accepted upstream.
> 
> Thanks for your work on this issue.
> Have a nice day.

Comment 5 Eduardo Otubo 2021-03-29 11:16:16 UTC
(In reply to xiachen from comment #4)
> Great! thanks for your notification.
> I think, Eduardo will do the backport to downstream according to his plan.
> 
> 
> (In reply to Nicolas Chauvet (kwizart) from comment #3)
> > (In reply to xiachen from comment #2)
> > Hello xiachen,
> > 
> > 
> > Just a notification that the PR have just been accepted upstream.
> > 
> > Thanks for your work on this issue.
> > Have a nice day.

I'm only waiting for the gitlab branches to be created.
I'll handle this bug as soon as we can.

Comment 6 Eduardo Otubo 2021-03-29 11:47:19 UTC
(In reply to Eduardo Otubo from comment #5)
> (In reply to xiachen from comment #4)
> > Great! thanks for your notification.
> > I think, Eduardo will do the backport to downstream according to his plan.
> > 
> > 
> > (In reply to Nicolas Chauvet (kwizart) from comment #3)
> > > (In reply to xiachen from comment #2)
> > > Hello xiachen,
> > > 
> > > 
> > > Just a notification that the PR have just been accepted upstream.
> > > 
> > > Thanks for your work on this issue.
> > > Have a nice day.
> 
> I'm only waiting for the gitlab branches to be created.
> I'll handle this bug as soon as we can.

Well, that was quick.
MR opened: https://gitlab.com/redhat/rhel/src/cloud-utils/-/merge_requests/1

Comment 10 Nicolas Chauvet (kwizart) 2021-05-07 22:12:29 UTC
Hello, any update on this fix ? I haven't seen it land in either c8s or c9s.

Thanks for any updates...

Comment 19 Rick Barry 2021-06-04 12:32:21 UTC
Clearing the needinfo's.

Comment 20 Nicolas Chauvet (kwizart) 2021-06-04 12:55:30 UTC
Thanks for the update on this. Can you please advertises the next steps ?
I don't see cloud-utils-growpart-0.31-2.el8 on git.centos.org yet...

Also I wonder how about the EL9 branch ?

Thanks in advances.

Comment 30 Carl George 🤠 2021-06-11 22:36:26 UTC
cloud-utils-growpart-0.31-2.el8 has been exported to git.c.o [0] and built in koji [1].  It should be included in the next CentOS Stream 8 compose.

[0] https://git.centos.org/rpms/cloud-utils-growpart/c/d4e673aff4f622b5d834f3c21b14e6fb7fcc5d56?branch=c8s
[1] https://koji.mbox.centos.org/koji/buildinfo?buildID=18024

Comment 34 errata-xmlrpc 2021-11-09 18:43:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (cloud-utils-growpart bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4264