Bug 1934476

Summary:	nmstatectl show does not quote interfaces names with float64
Product:	Red Hat Enterprise Linux 8	Reporter:	Quique Llorente <ellorent>
Component:	nmstate	Assignee:	Fernando F. Mancera <ferferna>
Status:	CLOSED UPSTREAM	QA Contact:	Mingyu Shi <mshi>
Severity:	medium	Docs Contact:
Priority:	high
Version:	8.2	CC:	ferferna, fge, jiji, jishi, mshi, network-qe, phoracek, till
Target Milestone:	rc	Keywords:	Triaged
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-09-30 08:57:30 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Quique Llorente 2021-03-03 10:39:13 UTC

Description of problem:

As noted by kubernetes-nmstate bz [1], when an interface has a floa64 name nmstatectl does not quote the name like it does with other numeric values.



Version-Release number of selected component (if applicable):
nmstate-0.2.6-14.el8_2

How reproducible: Always


Steps to Reproduce:
1. ip link add 60e+02 type dummy
2. nmstatectl show


Actual results:
name: 60e+02

Expected results:
name: '60e+02'


Additional info:

Looks like the issue is expected at yaml 1.1 but fixed at yaml 1.2 [1] and yaml 1.2 is not implemented at pyyaml [3]

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1926986
[2] https://github.com/yaml/pyyaml/issues/173#issuecomment-763045432
[3] https://yaml.readthedocs.io/en/latest/pyyaml.html

Comment 1 Petr Horáček 2021-05-03 09:20:31 UTC

Would you please see whether this is valid and prioritize? Thanks.

Comment 2 Fernando F. Mancera 2021-05-03 09:50:45 UTC

I think we have already discussed this with Quique. Quique, can you confirm that the workaround in kubernetes-nmstate is enough? Thanks!

Comment 3 Petr Horáček 2021-05-03 09:53:31 UTC

The workaround fixed our issue. The question is whether this needs a system fix, so it does not affect other users.

Comment 4 Fernando F. Mancera 2021-05-03 10:39:44 UTC

This depends on the pyyaml version installed. I think nmstate should not workaround it.. but we can include a warning for this. What do you think?

Comment 5 Till Maas 2021-05-03 11:41:22 UTC

(In reply to Fernando F. Mancera from comment #4)
> This depends on the pyyaml version installed. I think nmstate should not
> workaround it.. but we can include a warning for this. What do you think?

What version is that? I understood that nmstate would need to migrate to ruamel.yaml and then it would be good to declare the yaml interface of Nmstate to be using Yaml 1.2.

Comment 6 Quique Llorente 2021-05-04 06:03:02 UTC

(In reply to Fernando F. Mancera from comment #2)
> I think we have already discussed this with Quique. Quique, can you confirm
> that the workaround in kubernetes-nmstate is enough? Thanks!

Yes it fixed it, although it would be good to migrate nmstate to yaml 1.2.

Comment 7 Fernando F. Mancera 2021-05-06 08:19:15 UTC

(In reply to Till Maas from comment #5)
> (In reply to Fernando F. Mancera from comment #4)
> > This depends on the pyyaml version installed. I think nmstate should not
> > workaround it.. but we can include a warning for this. What do you think?
> 
> What version is that? I understood that nmstate would need to migrate to
> ruamel.yaml and then it would be good to declare the yaml interface of
> Nmstate to be using Yaml 1.2.

Oops. Yes, sorry I misunderstood the issue with a different one. Yes I agree nmstate should migrate to ruamel.yaml in order to use Yaml 1.2. Let me assign this to me. Thanks!

Comment 15 Fernando F. Mancera 2021-08-26 11:38:07 UTC

*** Bug 1994262 has been marked as a duplicate of this bug. ***

Comment 16 Gris Ge 2021-09-23 08:06:19 UTC

Hi Quique,

I assume CNV can use workaround by quoting them.
And this will been fixed by nmstate-rust(in 8.7).

Can I close this bug?

Comment 17 Red Hat Bugzilla 2023-09-15 01:02:39 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 500 days