Bug 193499
| Summary: | Review Request: XPad - A sticky notes application | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Gordon <peter> |
| Component: | Package Review | Assignee: | Thorsten Leemhuis (ignored mailbox) <bugzilla-sink> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | panemade |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-07-07 02:21:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peter Gordon
2006-05-29 22:15:53 UTC
Remove warnings xpad-pad.c: In function 'xpad_pad_notify_has_decorations': xpad-pad.c:411: warning: unused variable 'shown' xpad-pad.c: In function 'xpad_pad_show_toolbar': xpad-pad.c:455: warning: unused variable 'iter' xpad-pad.c:454: warning: unused variable 'y' xpad-pad.c:454: warning: unused variable 'x' xpad-pad.c:454: warning: unused variable 'texty' xpad-pad.c:454: warning: unused variable 'textx' xpad-pad.c:453: warning: unused variable 'rec' xpad-pad.c: In function 'xpad_pad_hide_toolbar': xpad-pad.c:490: warning: unused variable 'iter' xpad-pad.c:489: warning: unused variable 'y' xpad-pad.c:489: warning: unused variable 'x' xpad-pad.c:489: warning: unused variable 'texty' xpad-pad.c:489: warning: unused variable 'textx' xpad-pad.c:488: warning: unused variable 'rec' (In reply to comment #1) > Remove warnings > xpad-pad.c: In function 'xpad_pad_notify_has_decorations': > xpad-pad.c:411: warning: unused variable 'shown' Please note: Though some people might consider "unused variables" warnings to be ugly, they are fairly harmless and mostly safe to ignore. Thanks. I've added a patch (also sent upstream) to remove those unused variable declarations in 2.11-2. Spec: http://www.thecodergeek.com/downloads/fedora/xpad.spec SRPM: http://www.thecodergeek.com/downloads/fedora/xpad-2.11-2.src.rpm Review for this package:-
Mock Build Results for i386
- Failed to built for i386 as package required libSM-devel
- Add libSM-devel in Requires in SPEC file
MUST Items:
- MUST: rpmlint shows no error
- MUST: The package is named according to the Package Naming Guidelines.
- MUST: The spec file name matching the base package xpad, in the format
xpad.spec
- MUST: This package meets the Packaging Guidelines.
- MUST: The package is licensed with an open-source compatible license GPL.
- MUST: The License field in the package xpad.spec file matches the
actual license file COPYING in tarball.
- MUST: The sources used to build the package matches the upstream source,
as provided in the spec URL. md5sum is correct.
- MUST: This package owns all directories that it creates.
- MUST: This package did not contain any duplicate files in the %files
listing.
- MUST: This package have a %clean section, which contains rm -rf
%{buildroot}.
- MUST: This package used macros.
- MUST: Document files are included like README.
Above is Not an official review as I'm not yet sponsored I have not used XPad in a long time and have in fact found Tomboy to be incredibly useful for these purposes. Thus, I have no further intention to submit it to or maintain it in Extras, as I feel that maintaining a package which I do not actively use is inappropriate from a contributing standpoint, and would be very prone to me not being able to solve bugs or properly test things. I'm closing this as WONTFIX. If anyone wants to continue from my packaging, please feel free to do so. Space and bandwidth limitations notwithstanding, the spec file and source RPM as linked to from here will likely remain on my webspace indefinitely. |