Bug 1935177

Summary: presets: enable greenboot services by default
Product: Red Hat Enterprise Linux 8 Reporter: Christian Kellner <ckellner>
Component: redhat-releaseAssignee: Veronika Doubkova <vdoubkov>
Status: CLOSED WONTFIX QA Contact: Release Test Team <release-test-team>
Severity: unspecified Docs Contact: Eliane Ramos Pereira <elpereir>
Priority: unspecified    
Version: 8.4CC: akoutsou, elpereir, jwboyer, leiwang, lisas, perobins, xiaofwan
Target Milestone: rcKeywords: Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
.Greenboot services now enabled by default Previously, the greenboot services were not present in the default presets so, when the greenboot package was installed, users had to manually enable these greenboot services. With this update, the greenboot services are now present in the default presets configuration and users are no longer required to manually enable it.
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-09-04 07:27:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Christian Kellner 2021-03-04 13:49:39 UTC
Enable all the relevant greenboot services in the default presets so that when the greenboot package is installed it works out of the box without having to manually enable the services (which are actually quite a few).

Currently RHEL for Edge (and Fedora IoT) manually do this:

RHEL for Edge: https://github.com/osbuild/osbuild-composer/blob/f091af55d89ac9e77aa34b94e0180aacead3f32e/internal/distro/rhel84/distro.go#L830
Fedora IoT: https://pagure.io/fedora-iot/ostree/blob/main/f/fedora-iot-base.json#_131

Comment 4 Veronika Doubkova 2021-04-20 11:48:31 UTC
Hi Christian,
any progress in testing? Please let me know if I can push the changes and please set qa_ack and internal_target to 8.5.0. Scratch build with enabled services is available: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=36255452

Comment 5 Christian Kellner 2021-04-20 12:09:47 UTC
I talked to Xiofeng, and he is happy to do the testing and provide qa_ack but I am waiting for Peter to confirm that greenboot is not covered by somebody else. Peter, any news?

Comment 6 Xiaofeng Wang 2021-04-21 14:41:55 UTC
Services greenboot-grub2-set-counter greenboot-grub2-set-success greenboot-healthcheck greenboot-rpm-ostree-grub2-check-fallback greenboot-status greenboot-task-runner are all enabled, but redboot-auto-reboot and redboot-task-run are still disabled.

Build info:
[admin@vm-bios ~]$ rpm -qa |grep redhat-release
redhat-release-eula-8.5-0.2.el8.x86_64
redhat-release-8.5-0.2.el8.x86_64

How to reproduce:
1. install osbuild-composer which removed starting greenboot* and redboot* service part of code.
2. build container image with the following blueprint. "sudo composer-cli compose start-ostree --ref rhel/8/x86_64/edge container edge-container"
name = "container"
description = "A base rhel-edge container image"
version = "0.0.1"
modules = []
groups = []
[[packages]]
name = "python36"
version = "*"
[customizations.kernel]
name = "kernel-rt"
[[customizations.user]]
name = "admin"
description = "Administrator account"
password = "$6$GRmb7S0p8vsYmXzH$o0E020S.9JQGaHkszoog4ha4AQVs3sk8q0DvLjSMxoxHBKnB2FBXGQ/OkwZQfW/76ktHd0NX5nls2LPxPuUdl."
key = "ssh-rsa AAAAB3NzaC1yc2EAAAADAQABAAABgQCzxo5dEcS+LDK/OFAfHo6740EyoDM8aYaCkBala0FnWfMMTOq7PQe04ahB0eFLS3IlQtK5bpgzxBdFGVqF6uT5z4hhaPjQec0G3+BD5Pxo6V+SxShKZo+ZNGU3HVrF9p2V7QH0YFQj5B8F6AicA3fYh2BVUFECTPuMpy5A52ufWu0r4xOFmbU7SIhRQRAQz2u4yjXqBsrpYptAvyzzoN4gjUhNnwOHSPsvFpWoBFkWmqn0ytgHg3Vv9DlHW+45P02QH1UFedXR2MqLnwRI30qqtaOkVS+9rE/dhnR+XPpHHG+hv2TgMDAuQ3IK7Ab5m/yCbN73cxFifH4LST0vVG3Jx45xn+GTeHHhfkAfBSCtya6191jixbqyovpRunCBKexI5cfRPtWOitM3m7Mq26r7LpobMM+oOLUm4p0KKNIthWcmK9tYwXWSuGGfUQ+Y8gt7E0G06ZGbCPHOrxJ8lYQqXsif04piONPA/c9Hq43O99KPNGShONCS9oPFdOLRT3U= ostree-image-test"
home = "/home/admin/"
groups = ["wheel"]

3. run container
sudo podman pull "oci-archive:fd7d2717-6dfe-4b19-88ea-e707ac6f8e27-container.tar"
sudo podman network create --driver=bridge --subnet=192.168.200.0/24 --ip-range=192.168.200.0/24 --gateway=192.168.200.254 edge
sudo podman run -d --name rhel-edge --network edge --ip 192.168.200.1 <image id>

4. build installer image with the following blueprint. "sudo composer-cli compose start-ostree --ref rhel/8/x86_64/edge --url http://192.168.200.1/repo/ installer edge-installer"
name = "installer"
description = "A base rhel-edge installer image"
version = "0.0.1"
modules = []
groups = []

5. download iso
sudo composer-cli compose image <image id>

6. configure kickstart file
text
network --bootproto=dhcp --device=link --activate --onboot=on
zerombr
clearpart --all --initlabel --disklabel=msdos
autopart --nohome --noswap --type=plain
ostreesetup --nogpg --osname=rhel-edge --remote=rhel-edge --url=file:///ostree/repo --ref=rhel/8/x86_64/edge
poweroff
%post --log=/var/log/anaconda/post-install.log --erroronfail
# no sudo password for user admin
echo -e 'admin\tALL=(ALL)\tNOPASSWD: ALL' >> /etc/sudoers
%end

7. install
sudo virt-install --initrd-inject=ks.cfg --extra-args="inst.ks=file:/ks.cfg console=ttyS0,115200" --name=bios --disk path=/var/lib/libvirt/images/bios.qcow2,format=qcow2 --ram 3072 --vcpus 2 --network network=integration,mac=34:49:22:B0:83:30 --os-type linux --os-variant rhel8-unknown --nographics --noreboot --location /var/lib/libvirt/images/f6e1db12-f0da-4a91-83c4-8a6193237829-installer.iso

8. login with admin/foobar and check service status

Comment 7 Xiaofeng Wang 2021-04-22 05:39:33 UTC
Tested with redhat-release build from https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=36331029
All greenboot* and redboot* services are enabled and started.

[admin@vm-bios ~]$ rpm -qa |grep redhat-release
redhat-release-eula-8.5-0.2.el8.x86_64
redhat-release-8.5-0.2.el8.x86_64

[admin@vm-bios ~]$ rpm-ostree status
State: idle
Deployments:
* ostree://rhel-edge:rhel/8/x86_64/edge
                   Version: 8.5 (2021-04-22T02:47:52Z)
                    Commit: ca6875cefa8e3882a2ab27cd9911bdd979c76c3745b6935eda92025d26c3797d

[admin@vm-bios ~]$ systemctl is-enabled greenboot-grub2-set-counter greenboot-grub2-set-success greenboot-healthcheck greenboot-rpm-ostree-grub2-check-fallback greenboot-status greenboot-task-runner redboot-auto-reboot redboot-task-runner
enabled
enabled
enabled
enabled
enabled
enabled
enabled
enabled

Comment 8 Xiaofeng Wang 2021-04-22 06:13:54 UTC
Checked file /usr/lib/systemd/system-preset/90-default.preset

# enable greenboot services
# https://bugzilla.redhat.com/show_bug.cgi?id=1935177
enable greenboot-grub2-set-counter.service
enable greenboot-grub2-set-success.service
enable greenboot-healthcheck.service
enable greenboot-rpm-ostree-grub2-check-fallback.service
enable greenboot-status.service
enable greenboot-task-runner.service
enable redboot-auto-reboot.service
enable redboot-task-runner.service

Comment 9 Veronika Doubkova 2021-04-23 11:08:39 UTC
Build has been created:
Task info: https://brewweb.engineering.redhat.com/brew/taskinfo?taskID=36383921

Build added to the advisory:
https://errata.devel.redhat.com/advisory/68370

Comment 12 RHEL Program Management 2022-09-04 07:27:28 UTC
After evaluating this issue, there are no plans to address it further or fix it in an upcoming release.  Therefore, it is being closed.  If plans change such that this issue will be fixed in an upcoming release, then the bug can be reopened.