Bug 1935182

Summary: [OSP13] pep8 tests are failing in d/s CI
Product: Red Hat OpenStack Reporter: Roman Safronov <rsafrono>
Component: python-networking-ovnAssignee: Terry Wilson <twilson>
Status: CLOSED ERRATA QA Contact: Eran Kuris <ekuris>
Severity: low Docs Contact:
Priority: urgent    
Version: 13.0 (Queens)CC: apevec, egarciar, ffernand, lhh, majopela, scohen
Target Milestone: z16Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-networking-ovn-4.0.4-9.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-06-16 10:59:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Roman Safronov 2021-03-04 13:57:46 UTC
Description of problem:



TASK [run_tests : Running tests] ***********************************************
task path: /home/rhos-ci/jenkins/workspace/DFG-network-networking-ovn-13-pep8-rhos/infrared/plugins/octario/playbooks/roles/run_tests/tasks/main.yml:7
Thursday 04 March 2021  10:49:36 +0000 (0:00:00.164)       0:02:17.736 ******** 
fatal: [networking-ovn-19-1614854524-pep8-tester-0]: FAILED! => {
    "changed": false,
    "cmd": "export PATH=$PATH:/usr/sbin\nset -euo pipefail\nset -o pipefail; rpm -qa | sort > ../logs/installed-rpms.log;\ntruncate --size 0 requirements.txt; truncate --size 0 test-requirements.txt;\ngit checkout -- test-requirements.txt requirements.txt; tox -v -e pep8 2>&1 | tee ../logs/testrun.log;\n",
    "delta": "0:04:01.402972",
    "end": "2021-03-04 05:53:38.101770",
    "rc": 1,
    "start": "2021-03-04 05:49:36.698798"
}

STDOUT:

using tox.ini: /home/cloud-user/networking-ovn/tox.ini
using tox-2.3.2 from /usr/lib/python2.7/site-packages/tox/__init__.pyc
pep8 create: /home/cloud-user/networking-ovn/.tox/pep8
  /home/cloud-user/networking-ovn/.tox$ /usr/bin/python -m virtualenv --python /usr/bin/python2.7 pep8 >/home/cloud-user/networking-ovn/.tox/pep8/log/pep8-0.log
pep8 installdeps: -r/home/cloud-user/networking-ovn/requirements.txt, -r/home/cloud-user/networking-ovn/test-requirements.txt
  /home/cloud-user/networking-ovn$ /home/cloud-user/networking-ovn/tools/tox_install.sh https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/queens -r/home/cloud-user/networking-ovn/requirements.txt -r/home/cloud-user/networking-ovn/test-requirements.txt >/home/cloud-user/networking-ovn/.tox/pep8/log/pep8-1.log
pep8 develop-inst: /home/cloud-user/networking-ovn
  /home/cloud-user/networking-ovn$ /home/cloud-user/networking-ovn/tools/tox_install.sh https://git.openstack.org/cgit/openstack/requirements/plain/upper-constraints.txt?h=stable/queens -e /home/cloud-user/networking-ovn >/home/cloud-user/networking-ovn/.tox/pep8/log/pep8-2.log
  /home/cloud-user/networking-ovn$ /home/cloud-user/networking-ovn/.tox/pep8/bin/pip freeze >/home/cloud-user/networking-ovn/.tox/pep8/log/pep8-3.log
pep8 installed: You are using pip version 9.0.1, however version 21.0.1 is available.,You should consider upgrading via the 'pip install --upgrade pip' command.,alabaster==0.7.10,alembic==0.9.7,amqp==2.3.2,appdirs==1.4.3,asn1crypto==0.24.0,astroid==1.3.8,Babel==2.5.3,beautifulsoup4==4.6.0,cachetools==2.0.1,certifi==2018.1.18,cffi==1.11.4,chardet==3.0.4,cliff==2.11.1,cmd2==0.7.9,contextlib2==0.5.5,coverage==4.4.2,cryptography==2.1.4,debtcollector==1.19.0,decorator==4.2.1,deprecation==1.0.1,doc8==0.8.0,docutils==0.14,dogpile.cache==0.6.4,dulwich==0.18.6,enum-compat==0.0.2,enum34==1.1.6,eventlet==0.20.0,extras==1.0.0,fasteners==0.14.1,fixtures==3.0.0,flake8==2.5.5,flake8-import-order==0.12,funcsigs==1.0.2,functools32==3.2.3.post2,future==0.16.0,futures==3.2.0,futurist==1.6.0,greenlet==0.4.15,hacking==0.12.0,httplib2==0.10.3,idna==2.6,imagesize==0.7.1,ipaddress==1.0.19,iso8601==0.1.12,Jinja2==2.10,jmespath==0.9.3,jsonpatch==1.21,jsonpointer==2.0,jsonschema==2.6.0,keystoneauth1==3.4.1,keystonemiddleware==4.22.0,kombu==4.1.0,linecache2==1.0.0,logilab-common==1.4.4,logutils==0.3.5,Mako==1.0.7,MarkupSafe==1.0,mccabe==0.2.1,mock==2.0.0,monotonic==1.4,mox3==0.24.0,msgpack==0.5.1,msgpack-python==0.5.6,munch==2.2.0,netaddr==0.7.19,netifaces==0.10.6,-e git+https://code.engineering.redhat.com/gerrit/networking-ovn.git@4339eb5a87e30281b4aa842c6813e161b85b510c#egg=networking_ovn,-e git+https://git.openstack.org/openstack/neutron@a10a0cc3c4473b5062f53a8143233bab38935e79#egg=neutron,neutron-lib==1.13.0,openstackdocstheme==1.22.0,openstacksdk==0.11.4,os-client-config==1.29.0,os-service-types==1.1.0,os-testr==1.0.0,os-xenapi==0.3.1,osc-lib==1.9.0,oslo.cache==1.28.1,oslo.concurrency==3.25.1,oslo.config==5.2.1,oslo.context==2.20.0,oslo.db==4.33.4,oslo.i18n==3.19.0,oslo.log==3.36.0,oslo.messaging==5.35.6,oslo.middleware==3.34.0,oslo.policy==1.33.2,oslo.privsep==1.27.0,oslo.reports==1.26.0,oslo.rootwrap==5.13.0,oslo.serialization==2.24.0,oslo.service==1.29.1,oslo.utils==3.35.1,oslo.versionedobjects==1.31.3,oslotest==3.2.0,osprofiler==1.15.2,ovs==2.8.1,ovsdbapp==0.10.5,Paste==2.0.3,PasteDeploy==1.5.2,pbr==3.1.1,pecan==1.2.1,pep8==1.5.7,pika==0.10.0,pika-pool==0.1.3,prettytable==0.7.2,psutil==5.4.3,pycadf==2.7.0,pycodestyle==2.6.0,pycparser==2.18,pyflakes==0.8.1,Pygments==2.2.0,pyinotify==0.9.6,pylint==1.4.5,pyOpenSSL==17.5.0,pyparsing==2.2.0,pyperclip==1.6.0,pyroute2==0.4.21,python-dateutil==2.6.1,python-designateclient==2.9.0,python-editor==1.0.3,python-keystoneclient==3.15.1,python-mimeparse==1.6.0,python-neutronclient==6.7.0,python-novaclient==10.1.1,python-subunit==1.2.0,pytz==2017.3,PyYAML==3.12,reno==2.7.0,repoze.lru==0.7,requests==2.18.4,requestsexceptions==1.4.0,restructuredtext-lint==1.1.2,rfc3986==1.1.0,Routes==2.4.1,ryu==4.21,simplejson==3.13.2,singledispatch==3.4.0.3,six==1.11.0,snowballstemmer==1.2.1,Sphinx==1.6.5,sphinxcontrib-websupport==1.0.1,SQLAlchemy==1.2.1,sqlalchemy-migrate==0.11.0,sqlparse==0.2.4,statsd==3.2.2,stestr==2.0.0,stevedore==1.28.0,Tempita==0.5.2,tenacity==4.8.0,testrepository==0.0.20,testresources==2.0.1,testscenarios==0.5.0,testtools==2.3.0,tinyrpc==0.8,traceback2==1.4.0,typing==3.6.2,unicodecsv==0.14.1,unittest2==1.1.0,urllib3==1.22,vine==1.1.4,voluptuous==0.10.5,waitress==1.1.0,weakrefmethod==1.0.3,WebOb==1.7.4,WebTest==2.0.29,wrapt==1.10.11
pep8 runtests: PYTHONHASHSEED='3783913641'
pep8 runtests: commands[0] | flake8
  /home/cloud-user/networking-ovn$ /home/cloud-user/networking-ovn/.tox/pep8/bin/flake8 
./networking_ovn/common/maintenance.py:460:5: F811 redefinition of unused '_check_subnet_global_dhcp_opts' from line 347
    def _check_subnet_global_dhcp_opts(self):
    ^
./networking_ovn/common/maintenance.py:491:5: F811 redefinition of unused 'check_global_dhcp_opts' from line 378
    @periodics.periodic(spacing=600,
    ^
./networking_ovn/common/maintenance.py:525:5: F811 redefinition of unused 'check_metadata_ports' from line 412
    @periodics.periodic(spacing=1800, run_immediately=True)
    ^
./networking_ovn/common/maintenance.py:544:5: F811 redefinition of unused 'check_for_port_security_unknown_address' from line 431
    @periodics.periodic(spacing=600, run_immediately=True)
    ^
./networking_ovn/common/utils.py:442:1: F811 redefinition of unused 'is_neutron_dhcp_agent_port' from line 421
def is_neutron_dhcp_agent_port(port):
^
ERROR: InvocationError: '/home/cloud-user/networking-ovn/.tox/pep8/bin/flake8'
___________________________________ summary ____________________________________
ERROR:   pep8: commands failed

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 3 ffernand 2021-03-09 22:04:30 UTC
This has been fixed in https://code.engineering.redhat.com/gerrit/#/c/214587/
Need perms to merge or better yet, have a wholesale merge from upstream stable/queens

Comment 19 errata-xmlrpc 2021-06-16 10:59:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 13.0 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2385