Bug 1935753

Summary:	"Warning: Missing arginfo" - libguestfs needs porting for PHP 8
Product:	[Fedora] Fedora	Reporter:	Richard W.M. Jones <rjones>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	lersek, matt, mhicks, ngompa13, ptoscano, rjones
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2022-06-16 08:13:21 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Richard W.M. Jones 2021-03-05 13:41:24 UTC

Description of problem:

With PHP 8, "arginfo" is now mandatory:

$ php -n -d extension=./php/extension/.libs/guestfs_php.so

Warning: Missing arginfo for guestfs_create() in Unknown on line 0

Warning: Missing arginfo for guestfs_last_error() in Unknown on line 0

Warning: Missing arginfo for guestfs_acl_delete_def_file() in Unknown on line 0

Warning: Missing arginfo for guestfs_acl_get_file() in Unknown on line 0
...

Version-Release number of selected component (if applicable):

php-8.0.3-1.fc35.x86_64

How reproducible:

100%

Steps to Reproduce:
1. See above.

Additional info:

This is a bunch of extra work.  See:

https://www.seidengroup.com/2020/12/07/porting-extensions-to-php-8/

Comment 1 Laszlo Ersek 2022-02-15 13:56:26 UTC

[Libguestfs] libguestfs "test-mdadm.sh" and php tests failing?
https://listman.redhat.com/archives/libguestfs/2022-February/msg00205.html

Comment 2 Neal Gompa 2022-06-16 00:55:40 UTC

This has now been fixed upstream: https://github.com/libguestfs/libguestfs/commit/ec27979398b0871c1a3e0e244849f8435c9c9a8d

Could we see the php bindings shipped in Fedora and RHEL now?

Comment 3 Richard W.M. Jones 2022-06-16 07:42:05 UTC

I'll enable them in Rawhide.

As for RHEL I don't think we have ever enabled PHP bindings.  They are disabled
explicitly in RHEL 7 & 8, and in RHEL 9 they didn't work because of this
issue.  Who would use them?

Comment 4 Richard W.M. Jones 2022-06-16 07:52:47 UTC

https://koji.fedoraproject.org/koji/taskinfo?taskID=88322237