Bug 1936055

Summary: Review Request: php-pecl-xmlrpc - Functions to write XML-RPC servers and clients
Product: [Fedora] Fedora Reporter: Remi Collet <fedora>
Component: Package ReviewAssignee: Gwyn Ciesla <gwync>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: gwync, package-review
Target Milestone: ---Flags: gwync: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-09 14:35:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1935865    

Description Remi Collet 2021-03-06 08:02:16 UTC
Spec URL: https://rpms.remirepo.net/temp/php-pecl-xmlrpc.spec
SRPM URL: https://rpms.remirepo.net/temp/php-pecl-xmlrpc-1.0.0~rc2-2.fedora.src.rpm
This extension provides functions to write XML-RPC servers and clients.

You can find more information about XML-RPC at http://www.xmlrpc.com/,
and more documentation on this extension and its functions at

The extension is unbundled from php-src as of PHP 8.0.0, because the underlying
libxmlrpc has obviously been abandoned. It is recommended to reevaluate using
this extension.

Fedora Account System Username: remi

Comment 1 Remi Collet 2021-03-06 08:02:54 UTC
Koji scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=63189132

Comment 2 Gwyn Ciesla 2021-03-08 16:28:57 UTC
Package Review

[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

===== MUST items =====

[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[-]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "*No copyright* Public domain". 71
     files have unknown license. Detailed output of licensecheck in
[x]: License file installed when any subpackage combination is installed.
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 3 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.

[!]: Run phpci static analyze on all php files.
     Note: phpcompatinfo not found. Install php-bartlett-PHP-CompatInfo
     package to get a more comprehensive php review.
     See: url: undefined

Checking: php-pecl-xmlrpc-1.0.0~rc2-2.fc35.x86_64.rpm
php-pecl-xmlrpc.x86_64: W: spelling-error %description -l en_US unbundled -> bundled, unbounded, bundle
php-pecl-xmlrpc.x86_64: W: spelling-error %description -l en_US src -> arc, sec, sic
php-pecl-xmlrpc.src: W: spelling-error %description -l en_US unbundled -> bundled, unbounded, bundle
php-pecl-xmlrpc.src: W: spelling-error %description -l en_US src -> arc, sec, sic
php-pecl-xmlrpc.src: W: spelling-error %description -l en_US libxmlrpc 
4 packages and 0 specfiles checked; 0 errors, 5 warnings.

Rpmlint (debuginfo)
Checking: php-pecl-xmlrpc-debuginfo-1.0.0~rc2-2.fc35.x86_64.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages)
php-pecl-xmlrpc.x86_64: W: spelling-error %description -l en_US unbundled -> bundled, unbounded, bundle
php-pecl-xmlrpc.x86_64: W: spelling-error %description -l en_US src -> arc, sec, sic
3 packages and 0 specfiles checked; 0 errors, 2 warnings.

Unversioned so-files
php-pecl-xmlrpc: /usr/lib64/php-zts/modules/xmlrpc.so
php-pecl-xmlrpc: /usr/lib64/php/modules/xmlrpc.so

Source checksums
https://pecl.php.net/get/xmlrpc-1.0.0RC2.tgz :
  CHECKSUM(SHA256) this package     : 9800a5f627c24e2f6acf61f816a54c66e9fdffbfabc598ffc0f0f1165d3ef041
  CHECKSUM(SHA256) upstream package : 9800a5f627c24e2f6acf61f816a54c66e9fdffbfabc598ffc0f0f1165d3ef041

php-pecl-xmlrpc (rpmlib, GLIBC filtered):

php-pecl-xmlrpc-debuginfo (rpmlib, GLIBC filtered):

php-pecl-xmlrpc-debugsource (rpmlib, GLIBC filtered):




Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10
Command line :/usr/bin/fedora-review -b 1936055
Buildroot used: fedora-rawhide-x86_64
Active plugins: PHP, Shell-api, C/C++, Generic
Disabled plugins: Java, R, Python, Ocaml, Perl, Haskell, fonts, SugarActivity

I'd like to see phpci added but since the test suite works I'm not concerned.  Thank you for packaging this so quickly, thoroughly, and well.


Comment 3 Remi Collet 2021-03-09 05:43:52 UTC
> I'd like to see phpci added but since the test suite works I'm not concerned. 

phpci (php-bartlett-PHP-CompatInfo) is a static analyser for PHP library, so doesn't make sense for a C extension

Thanks for the review

SCL request


Comment 4 Gwyn Ciesla 2021-03-09 14:03:05 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/php-pecl-xmlrpc

Comment 5 Gwyn Ciesla 2021-03-09 14:03:17 UTC
Ah, that makes sense.

Comment 6 Remi Collet 2021-03-09 14:35:22 UTC
Built in rawhide